Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swarm is not ICollection<Peer> anymore #326

Merged
merged 4 commits into from Jul 3, 2019

Conversation

Projects
None yet
4 participants
@limebell
Copy link
Contributor

commented Jul 3, 2019

Added changelog

limebell added some commits Jul 3, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #326 into master will increase coverage by 0.34%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   87.34%   87.68%   +0.34%     
==========================================
  Files         189      189              
  Lines       12767    12711      -56     
==========================================
- Hits        11151    11146       -5     
+ Misses       1366     1315      -51     
  Partials      250      250
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 77.46% <100%> (+2.62%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 92.38% <86.66%> (+0.04%) ⬆️
Libplanet/Net/NoSwarmContextException.cs 25% <0%> (+25%) ⬆️

@earlbread earlbread requested review from longfin, earlbread and dahlia and removed request for longfin and earlbread Jul 3, 2019

Show resolved Hide resolved CHANGES.md Outdated
Update CHANGES.md
Co-Authored-By: Seunghun Lee <waydi1@gmail.com>
@dahlia

dahlia approved these changes Jul 3, 2019

@longfin

longfin approved these changes Jul 3, 2019

@longfin longfin merged commit 5be73dc into planetarium:master Jul 3, 2019

16 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 87.5% of diff hit (target 87.34%)
Details
codecov/project 87.68% (+0.34%) compared to 5e554ca
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190703.15 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
@longfin

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Thanks for contribution! 🎉

@limebell limebell deleted the limebell:remove-collection branch Jul 10, 2019

@limebell limebell restored the limebell:remove-collection branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.