Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ReceiveMessageAsync to poller #327

Merged
merged 2 commits into from Jul 4, 2019

Conversation

Projects
None yet
3 participants
@earlbread
Copy link
Member

commented Jul 3, 2019

This fixes #321 using NetMQPoller to receive messages.

@earlbread earlbread self-assigned this Jul 3, 2019

@earlbread earlbread force-pushed the earlbread:receive-message-poller branch 2 times, most recently from e2edca2 to 2ca072f Jul 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 4, 2019

Codecov Report

Merging #327 into master will decrease coverage by 0.11%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
- Coverage   87.81%   87.69%   -0.12%     
==========================================
  Files         189      189              
  Lines       12781    12749      -32     
==========================================
- Hits        11223    11180      -43     
- Misses       1308     1319      +11     
  Partials      250      250
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 77.53% <66.66%> (-0.82%) ⬇️
Libplanet/Net/NoSwarmContextException.cs 0% <0%> (-25%) ⬇️
Libplanet/Net/NetMQSocketExtension.cs 31.91% <0%> (-10.64%) ⬇️

@earlbread earlbread marked this pull request as ready for review Jul 4, 2019

@earlbread earlbread requested review from longfin and dahlia Jul 4, 2019

@earlbread earlbread added the bug label Jul 4, 2019

@earlbread earlbread added this to the 0.4.0 milestone Jul 4, 2019

Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved Libplanet/Net/Swarm.cs Outdated
Show resolved Hide resolved Libplanet.Tests/Net/SwarmTest.cs Outdated

@earlbread earlbread force-pushed the earlbread:receive-message-poller branch 3 times, most recently from 85f64ed to fa1ae9b Jul 4, 2019

@earlbread earlbread requested review from longfin and dahlia Jul 4, 2019

earlbread and others added some commits Jul 3, 2019

Move ReceiveMessageAsync to poller
Co-Authored-By: Swen Mun <longfinfunnel@gmail.com>

@earlbread earlbread force-pushed the earlbread:receive-message-poller branch from fa1ae9b to 3520e8f Jul 4, 2019

@earlbread

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

I rebased this because #330 has been merged.

@longfin

longfin approved these changes Jul 4, 2019

@dahlia

dahlia approved these changes Jul 4, 2019

@dahlia dahlia merged commit 9a2699b into planetarium:master Jul 4, 2019

14 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190704.18 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details

@earlbread earlbread deleted the earlbread:receive-message-poller branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.