Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change return value of LookupStateReference #350

Merged

Conversation

Projects
None yet
3 participants
@earlbread
Copy link
Member

commented Jul 11, 2019

This removes LookupStateReferenceWithIndex(), a temporary method to ensure backward compatibility with 0.4.1, and changes the return value of LookupStateReference().

@earlbread earlbread requested review from dahlia and longfin Jul 11, 2019

@earlbread earlbread self-assigned this Jul 11, 2019

@dahlia

dahlia approved these changes Jul 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 11, 2019

Codecov Report

Merging #350 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
- Coverage    87.7%   87.68%   -0.03%     
==========================================
  Files         189      189              
  Lines       12808    12803       -5     
==========================================
- Hits        11233    11226       -7     
- Misses       1324     1326       +2     
  Partials      251      251
Impacted Files Coverage Δ
Libplanet/Store/StoreExtension.cs 85.71% <ø> (-3.76%) ⬇️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.78% <100%> (ø) ⬆️
Libplanet/Blockchain/BlockChain.cs 95.61% <100%> (ø) ⬆️
Libplanet.Tests/Store/StoreTest.cs 98.75% <100%> (ø) ⬆️
Libplanet.Tests/Store/StoreExtensionTest.cs 100% <100%> (ø) ⬆️
Libplanet/Net/Swarm.cs 76.84% <0%> (-0.17%) ⬇️

@earlbread earlbread merged commit f418686 into planetarium:master Jul 11, 2019

16 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 87.7%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +12.29% compared to b889e9a
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190711.13 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details

@earlbread earlbread deleted the earlbread:change-lookup-state-reference branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.