Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation order of transactions in a block #355

Conversation

@moreal
Copy link
Contributor

commented Jul 16, 2019

No description provided.

@moreal moreal force-pushed the moreal:define-evaluation-order-of-transactions-in-a-block-244 branch 2 times, most recently from aa82460 to 26bf074 Jul 26, 2019
@moreal moreal marked this pull request as ready for review Jul 27, 2019
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Libplanet/Blocks/Block.cs Outdated Show resolved Hide resolved
Libplanet/Blockchain/BlockChain.cs Outdated Show resolved Hide resolved
@moreal moreal force-pushed the moreal:define-evaluation-order-of-transactions-in-a-block-244 branch from d9ba32d to 993d3d0 Aug 2, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 2, 2019

Codecov Report

Merging #355 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   89.98%   90.04%   +0.05%     
==========================================
  Files         200      200              
  Lines       14552    14678     +126     
==========================================
+ Hits        13095    13217     +122     
- Misses       1173     1176       +3     
- Partials      284      285       +1
Impacted Files Coverage Δ
Libplanet.Tests/Store/StoreFixture.cs 100% <100%> (ø) ⬆️
Libplanet/Blocks/Block.cs 86.69% <100%> (+0.31%) ⬆️
Libplanet.Tests/Blocks/BlockTest.cs 98.06% <100%> (+0.03%) ⬆️
Libplanet.Tests/Tx/TxFixture.cs 100% <100%> (ø) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 97.85% <100%> (ø) ⬆️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.47% <100%> (+0.06%) ⬆️
Libplanet.Tests/Common/Action/DumbAction.cs 80% <100%> (+2.95%) ⬆️
Libplanet/Net/Protocols/KademliaProtocol.cs 60.23% <0%> (-0.88%) ⬇️
Libplanet/Crypto/PrivateKey.cs 85.34% <0%> (-0.87%) ⬇️
@moreal moreal force-pushed the moreal:define-evaluation-order-of-transactions-in-a-block-244 branch 2 times, most recently from 3da1a1e to 7867fb6 Aug 5, 2019
@moreal moreal force-pushed the moreal:define-evaluation-order-of-transactions-in-a-block-244 branch 2 times, most recently from e499c6d to 6c6d361 Aug 19, 2019
Libplanet/Blocks/Block.cs Outdated Show resolved Hide resolved
@moreal moreal force-pushed the moreal:define-evaluation-order-of-transactions-in-a-block-244 branch from 6c6d361 to 213bdf6 Aug 21, 2019
@longfin longfin added this to the 0.6.0 milestone Aug 22, 2019
CHANGES.md Outdated Show resolved Hide resolved
Libplanet/Blocks/Block.cs Outdated Show resolved Hide resolved
@moreal moreal force-pushed the moreal:define-evaluation-order-of-transactions-in-a-block-244 branch 3 times, most recently from f2fa5cd to c1802f3 Aug 28, 2019
@dahlia dahlia requested review from earlbread and limebell Sep 3, 2019
Copy link
Member

left a comment

Commits need to be rebased on the current master.

Libplanet/Blocks/InvalidBlockTransactionsException.cs Outdated Show resolved Hide resolved
Libplanet/Blockchain/BlockChain.cs Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Libplanet/Tx/TxId.cs Outdated Show resolved Hide resolved
Libplanet/Blocks/InvalidBlockTransactionsException.cs Outdated Show resolved Hide resolved
Libplanet/Blocks/Block.cs Show resolved Hide resolved
@moreal moreal force-pushed the moreal:define-evaluation-order-of-transactions-in-a-block-244 branch 2 times, most recently from 60b7f34 to def746c Sep 3, 2019
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@moreal moreal force-pushed the moreal:define-evaluation-order-of-transactions-in-a-block-244 branch from 189f7ae to 030e1eb Sep 3, 2019
CHANGES.md Outdated Show resolved Hide resolved
@dahlia

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

@moreal You need to rebase this on the current master again.

@moreal moreal force-pushed the moreal:define-evaluation-order-of-transactions-in-a-block-244 branch 3 times, most recently from fa640bf to b156211 Sep 4, 2019
@moreal moreal force-pushed the moreal:define-evaluation-order-of-transactions-in-a-block-244 branch from 6274e34 to 1778be7 Sep 4, 2019
@@ -41,6 +42,12 @@ public class Block<T> : ISerializable
Timestamp = timestamp;
Transactions = transactions.ToArray();

This comment has been minimized.

Copy link
@limebell

limebell Sep 4, 2019

Contributor

Is this property still required?

This comment has been minimized.

Copy link
@moreal

moreal Sep 4, 2019

Author Contributor

I remained it to reduce a cost of the process to check tx nonces.
But In my thought, it can use a lot of memory.

This comment has been minimized.

Copy link
@limebell

limebell Sep 5, 2019

Contributor

It will be great if OrderedTransactions is stored once it's calculated. IMO removing Transactions property can be delayed after then.

@limebell limebell self-requested a review Sep 4, 2019
@moreal moreal force-pushed the moreal:define-evaluation-order-of-transactions-in-a-block-244 branch from 1778be7 to 44e63a5 Sep 5, 2019
@moreal moreal force-pushed the moreal:define-evaluation-order-of-transactions-in-a-block-244 branch from 44e63a5 to f78def0 Sep 5, 2019
@longfin
longfin approved these changes Sep 6, 2019
@dahlia
dahlia approved these changes Sep 6, 2019
@dahlia dahlia merged commit b5ed4ec into planetarium:master Sep 6, 2019
17 of 18 checks passed
17 of 18 checks passed
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage failed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 89.98%)
Details
codecov/project 90.04% (+0.05%) compared to 21ac8d8
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190905.12 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.