Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Swarm's direct access code to store atomic #363

Merged
merged 5 commits into from Jul 23, 2019

Conversation

@dahlia
Copy link
Member

commented Jul 22, 2019

It's only temporary code in a transition code.

@dahlia dahlia added the bug label Jul 22, 2019

@dahlia dahlia added this to the 0.5.0 milestone Jul 22, 2019

@dahlia dahlia self-assigned this Jul 22, 2019

@dahlia dahlia force-pushed the dahlia:swarm-blockchain-store-access branch from ef6ed36 to d34ad5d Jul 22, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 22, 2019

Codecov Report

Merging #363 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   88.01%   88.05%   +0.03%     
==========================================
  Files         192      192              
  Lines       13454    13447       -7     
==========================================
- Hits        11842    11841       -1     
+ Misses       1343     1337       -6     
  Partials      269      269
Impacted Files Coverage Δ
Libplanet/Blockchain/BlockChain.cs 95.78% <ø> (ø) ⬆️
Libplanet/Net/Swarm.cs 79.27% <100%> (+0.15%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 93.05% <0%> (+0.76%) ⬆️
@codecov

This comment has been minimized.

Copy link

commented Jul 22, 2019

Codecov Report

Merging #363 into master will increase coverage by 0.12%.
The diff coverage is 97.68%.

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   88.13%   88.25%   +0.12%     
==========================================
  Files         192      193       +1     
  Lines       13500    13641     +141     
==========================================
+ Hits        11898    12039     +141     
+ Misses       1332     1330       -2     
- Partials      270      272       +2
Impacted Files Coverage Δ
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.28% <100%> (+0.04%) ⬆️
Libplanet/Net/Swarm.cs 78.69% <100%> (-0.17%) ⬇️
Libplanet/Store/StoreExtension.cs 92% <100%> (+6.28%) ⬆️
Libplanet.Tests/Blockchain/NullPolicy.cs 100% <100%> (ø)
Libplanet/Address.cs 93.33% <100%> (+1.56%) ⬆️
Libplanet.Tests/Store/StoreExtensionTest.cs 100% <100%> (ø) ⬆️
Libplanet/Blockchain/BlockChain.cs 95.47% <91.66%> (-0.35%) ⬇️
Libplanet.Tests/AddressTest.cs 95.38% <93.33%> (-0.38%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 93.16% <0%> (+0.11%) ⬆️
... and 1 more
dahlia added 2 commits Jul 22, 2019
Make Swarm's direct access code to store atomic
It's only temporary code in a transition code.

[changelog skip]

@dahlia dahlia force-pushed the dahlia:swarm-blockchain-store-access branch 3 times, most recently from 523ee23 to e0fda6d Jul 23, 2019

@dahlia dahlia marked this pull request as ready for review Jul 23, 2019

@dahlia dahlia requested review from longfin and earlbread Jul 23, 2019

CHANGES.md Outdated Show resolved Hide resolved

@dahlia dahlia force-pushed the dahlia:swarm-blockchain-store-access branch from e0fda6d to 8886884 Jul 23, 2019

@dahlia dahlia requested review from earlbread and longfin Jul 23, 2019

@dahlia dahlia merged commit 19078be into planetarium:master Jul 23, 2019

14 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190723.13 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.