Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transaction to pending that have the future nonce #365

Merged
merged 2 commits into from Jul 23, 2019

Conversation

@longfin
Copy link
Member

commented Jul 22, 2019

This PR reverts #362 and introduces another solution that makes transactions having the future nonce to pending and ignores them.

@longfin longfin force-pushed the longfin:bugfix/txnonce branch from 555988a to ca6130f Jul 22, 2019

@longfin longfin marked this pull request as ready for review Jul 22, 2019

@dahlia
dahlia approved these changes Jul 22, 2019
@codecov

This comment has been minimized.

Copy link

commented Jul 22, 2019

Codecov Report

Merging #365 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   88.01%   88.04%   +0.02%     
==========================================
  Files         192      192              
  Lines       13454    13482      +28     
==========================================
+ Hits        11842    11870      +28     
+ Misses       1343     1341       -2     
- Partials      269      271       +2
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 78.79% <ø> (-0.34%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 92.1% <ø> (-0.18%) ⬇️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.24% <100%> (+0.11%) ⬆️
Libplanet/Blockchain/BlockChain.cs 95.81% <100%> (+0.02%) ⬆️
Libplanet/Crypto/PrivateKey.cs 84.68% <0%> (-0.91%) ⬇️
Libplanet/Tx/Transaction.cs 95.62% <0%> (+1.01%) ⬆️

@longfin longfin merged commit 8bf96ad into planetarium:master Jul 23, 2019

16 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 88.01%)
Details
codecov/project 88.04% (+0.02%) compared to 36f3e8c
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190722.16 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.