Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiteDBStore.IterateStagedTransactionIds() should returns unique txids #366

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@longfin
Copy link
Member

commented Jul 22, 2019

This PR fixes a bug that LiteDBStore.IterateStagedTransactionIds() returns duplicated transaction ids.

@longfin longfin force-pushed the longfin:bugfix/duplicated-staged-txids branch from 781524b to 6972c5a Jul 22, 2019

@longfin longfin marked this pull request as ready for review Jul 22, 2019

@dahlia
Copy link
Member

left a comment

If the order of return values are arbitrary it might be better to be IImmutableSet<TxId> instead in the future.

@codecov

This comment has been minimized.

Copy link

commented Jul 22, 2019

Codecov Report

Merging #366 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage    88.1%   88.14%   +0.04%     
==========================================
  Files         192      192              
  Lines       13482    13500      +18     
==========================================
+ Hits        11878    11900      +22     
+ Misses       1333     1330       -3     
+ Partials      271      270       -1
Impacted Files Coverage Δ
Libplanet.Tests/Store/StoreTest.cs 98.8% <100%> (+0.04%) ⬆️
Libplanet/Store/LiteDBStore.cs 92.63% <100%> (+0.03%) ⬆️
Libplanet/Net/Swarm.cs 79% <0%> (+0.21%) ⬆️
Libplanet/Crypto/PrivateKey.cs 85.58% <0%> (+0.9%) ⬆️

@longfin longfin requested a review from earlbread Jul 23, 2019

CHANGES.md Outdated Show resolved Hide resolved

@longfin longfin force-pushed the longfin:bugfix/duplicated-staged-txids branch from 82cf0a7 to 781dae9 Jul 23, 2019

@longfin longfin requested review from earlbread and dahlia Jul 23, 2019

@longfin longfin merged commit 15194a5 into planetarium:master Jul 23, 2019

16 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 88.1%)
Details
codecov/project 88.14% (+0.04%) compared to 8bf96ad
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190723.2 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.