Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug when serializing default address #369

Merged

Conversation

@longfin
Copy link
Member

commented Jul 24, 2019

This PR fixes a bug that NullReferenceException occurred when serializing default Address.

@longfin longfin force-pushed the longfin:bugfix/serialize-default-address branch from b96ade5 to ff407a4 Jul 24, 2019

Libplanet/Blockchain/BlockChain.cs Outdated Show resolved Hide resolved

@longfin longfin force-pushed the longfin:bugfix/serialize-default-address branch from ff407a4 to 3c84d82 Jul 24, 2019

@longfin longfin marked this pull request as ready for review Jul 24, 2019

@longfin longfin dismissed stale reviews from earlbread and dahlia via 7ad9db2 Jul 25, 2019

@longfin longfin force-pushed the longfin:bugfix/serialize-default-address branch from 3c84d82 to 7ad9db2 Jul 25, 2019

@longfin longfin requested review from dahlia and earlbread Jul 25, 2019

@dahlia
dahlia approved these changes Jul 25, 2019
@codecov

This comment has been minimized.

Copy link

commented Jul 25, 2019

Codecov Report

Merging #369 into master will decrease coverage by 4.63%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
- Coverage   88.26%   83.62%   -4.64%     
==========================================
  Files         195      171      -24     
  Lines       13834    13164     -670     
==========================================
- Hits        12210    11008    -1202     
- Misses       1351     1912     +561     
+ Partials      273      244      -29
Impacted Files Coverage Δ
Libplanet/Address.cs 93.33% <100%> (ø) ⬆️
Libplanet.Tests/AddressTest.cs 95.63% <100%> (+0.24%) ⬆️
Libplanet.Stun/Stun/Attributes/ErrorCode.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Attributes/Lifetime.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Attributes/Nonce.cs 0% <0%> (-100%) ⬇️
...anet.Stun/Stun/Messages/CreatePermissionRequest.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Messages/BindingRequest.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Attributes/Realm.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Attributes/Fingerprint.cs 0% <0%> (-100%) ⬇️
...planet.Stun/Stun/Messages/ConnectionBindRequest.cs 0% <0%> (-100%) ⬇️
... and 45 more

@longfin longfin merged commit b69c8cf into planetarium:master Jul 25, 2019

16 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 88.26%)
Details
codecov/project Absolute coverage decreased by -4.63% but relative coverage increased by +11.73% compared to df59b18
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190725.3 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.