Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unintended delays in `Swarm<T>.ProcessDeltaAsync()` #375

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@longfin
Copy link
Member

commented Jul 29, 2019

This PR removes Swarm<T>._receiveMutex to avoid continuous delays about peer registration (using .ApplyDelta).

@longfin longfin force-pushed the longfin:bugfix/remove-receive-mutex branch from 0b2a972 to 8b9c60b Jul 29, 2019

@longfin longfin marked this pull request as ready for review Jul 29, 2019

@longfin longfin force-pushed the longfin:bugfix/remove-receive-mutex branch from 8b9c60b to cb1a8a8 Jul 30, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 30, 2019

Codecov Report

Merging #375 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   88.26%   88.22%   -0.05%     
==========================================
  Files         195      195              
  Lines       13852    13847       -5     
==========================================
- Hits        12227    12217      -10     
- Misses       1349     1353       +4     
- Partials      276      277       +1
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 78.3% <100%> (-0.3%) ⬇️
Libplanet/Crypto/PrivateKey.cs 84.68% <0%> (-0.91%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 93.13% <0%> (-0.12%) ⬇️

@longfin longfin requested review from earlbread and dahlia Jul 30, 2019

@dahlia
dahlia approved these changes Jul 31, 2019

@longfin longfin merged commit 6416996 into planetarium:master Aug 1, 2019

16 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 88.26%)
Details
codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +11.73% compared to 046c15f
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190730.4 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.