Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #377 #378

Merged
merged 2 commits into from Aug 2, 2019

Conversation

@longfin
Copy link
Member

commented Jul 30, 2019

This PR fixes #377

@longfin longfin force-pushed the longfin:bugfix/377 branch from ab71885 to 1e49251 Jul 30, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 30, 2019

Codecov Report

Merging #378 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   88.28%   88.22%   -0.06%     
==========================================
  Files         195      195              
  Lines       13847    13848       +1     
==========================================
- Hits        12225    12218       -7     
- Misses       1346     1354       +8     
  Partials      276      276
Impacted Files Coverage Δ
Libplanet.Stun/Stun/TurnClient.cs 0% <0%> (ø) ⬆️
Libplanet/Net/Swarm.cs 78.3% <0%> (-0.5%) ⬇️

@longfin longfin force-pushed the longfin:bugfix/377 branch from 1e49251 to d04822c Jul 30, 2019

@longfin longfin marked this pull request as ready for review Jul 30, 2019

@longfin longfin requested review from earlbread and dahlia Jul 30, 2019

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved

@longfin longfin requested review from dahlia and earlbread Jul 31, 2019

longfin and others added 2 commits Jul 30, 2019
Apply suggestions from code review
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>

@longfin longfin force-pushed the longfin:bugfix/377 branch from b30f1ee to 6f4e42c Aug 1, 2019

@longfin longfin requested a review from earlbread Aug 1, 2019

@dahlia
dahlia approved these changes Aug 1, 2019

@longfin longfin merged commit 21fef6a into planetarium:master Aug 2, 2019

15 of 16 checks passed

codecov/patch 0% of diff hit (target 88.28%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 88.22% (-0.06%) compared to 6416996
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190801.7 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.