Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around LiteDB's file storage bug #386

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@dahlia
Copy link
Member

commented Aug 1, 2019

This patch works around mbdavid/LiteDB#1268.

@dahlia dahlia added the bug label Aug 1, 2019

@dahlia dahlia added this to the 0.5.0 milestone Aug 1, 2019

@dahlia dahlia requested review from longfin and earlbread Aug 1, 2019

@dahlia dahlia self-assigned this Aug 1, 2019

@longfin
longfin approved these changes Aug 1, 2019

@dahlia dahlia merged commit 87fcbe6 into planetarium:9c-fft Aug 1, 2019

12 of 14 checks passed

planetarium.libplanet Build #20190801.9 failed
Details
planetarium.libplanet (Windows_Mono) Windows_Mono failed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
dahlia added a commit to dahlia/libplanet that referenced this pull request Aug 2, 2019
Revert prev workaround for LiteDB and make it flush instead
It turns out that LiteDB's data corruption
(mbdavid/LiteDB#1268) seems to happen
due to sudden termination of program.  So the workaround made in the
previous patch (planetarium#386)
was reverted for the most part, and a new option named `flush` was
added to `LiteDBStore()` constructor.
dahlia added a commit to dahlia/libplanet that referenced this pull request Aug 2, 2019
Revert prev workaround for LiteDB and make it flush instead
It turns out that LiteDB's data corruption
(mbdavid/LiteDB#1268) seems to happen
due to sudden termination of program.  So the workaround made in the
previous patch (planetarium#386)
was reverted for the most part, and a new option named `flush` was
added to `LiteDBStore()` constructor.
longfin added a commit to longfin/libplanet.net that referenced this pull request Aug 6, 2019
Revert prev workaround for LiteDB and make it flush instead
It turns out that LiteDB's data corruption
(mbdavid/LiteDB#1268) seems to happen
due to sudden termination of program.  So the workaround made in the
previous patch (planetarium#386)
was reverted for the most part, and a new option named `flush` was
added to `LiteDBStore()` constructor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.