Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ffwd already had blocks without fetch during preloading phase #389

Merged
merged 2 commits into from Aug 2, 2019

Conversation

@dahlia
Copy link
Member

commented Aug 2, 2019

As BlockChain<T>.GetEnumerator() always fetches block data and instantiates actual Block<T> objects, skipping on that still had a lot of redundant operations. This patch fixes that inefficiency.

@dahlia dahlia added the bug label Aug 2, 2019

@dahlia dahlia added this to the 0.5.0 milestone Aug 2, 2019

@dahlia dahlia requested review from longfin and earlbread Aug 2, 2019

@dahlia dahlia self-assigned this Aug 2, 2019

@longfin
longfin approved these changes Aug 2, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 2, 2019

Codecov Report

Merging #389 into 9c-fft will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           9c-fft     #389      +/-   ##
==========================================
+ Coverage    88.1%   88.14%   +0.03%     
==========================================
  Files         193      193              
  Lines       13723    13741      +18     
==========================================
+ Hits        12091    12112      +21     
+ Misses       1344     1341       -3     
  Partials      288      288
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 78.87% <100%> (+0.01%) ⬆️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.3% <100%> (+0.02%) ⬆️
Libplanet/Blockchain/BlockChain.cs 95.5% <100%> (+0.02%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 93.92% <0%> (+0.34%) ⬆️

@dahlia dahlia merged commit 582604b into planetarium:9c-fft Aug 2, 2019

16 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 88.1%)
Details
codecov/project 88.14% (+0.03%) compared to 168ac4a
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190802.11 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.