Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune BaseIndex.ContainsKey() #390

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@longfin
Copy link
Member

commented Aug 2, 2019

This PR tunes BlockSet<T>.ContainsKey() and TransactionSet<T>.ContainsKey() to accomplish lookup in O(1).

@longfin longfin requested a review from dahlia Aug 2, 2019

@longfin longfin force-pushed the longfin:feature/o1-block-tx-set branch from f6d3725 to 2b678a0 Aug 2, 2019

@longfin longfin marked this pull request as ready for review Aug 2, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 2, 2019

Codecov Report

Merging #390 into 9c-fft will decrease coverage by 7.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           9c-fft     #390      +/-   ##
==========================================
- Coverage   88.14%   80.17%   -7.97%     
==========================================
  Files         193       61     -132     
  Lines       13769     1513   -12256     
==========================================
- Hits        12136     1213   -10923     
+ Misses       1344      271    -1073     
+ Partials      289       29     -260
Impacted Files Coverage Δ
Libplanet/Net/Messages/BlockHashes.cs
Libplanet/Net/NoSwarmContextException.cs
Libplanet.Tests/Action/ActionEvaluationTest.cs
Libplanet.Tests/Store/StoreTest.cs
Libplanet.Tests/Store/FileStoreTest.cs
Libplanet/Blocks/Block.cs
Libplanet/Net/PeerSetDelta.cs
...planet/Blockchain/Policies/BlockPolicyExtension.cs
Libplanet/Blocks/InvalidBlockTimestampException.cs
Libplanet/Net/Messages/PeerSetDelta.cs
... and 118 more

@longfin longfin force-pushed the longfin:feature/o1-block-tx-set branch from 4a9bce6 to ac570ff Aug 2, 2019

@longfin longfin force-pushed the longfin:feature/o1-block-tx-set branch from ac570ff to bdcd176 Aug 2, 2019

@dahlia
dahlia approved these changes Aug 5, 2019

@longfin longfin merged commit 453f3e5 into planetarium:9c-fft Aug 5, 2019

14 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190802.19 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.