Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient way to store state references #398

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@dahlia
Copy link
Member

commented Aug 5, 2019

This fixes #395.

@dahlia dahlia added the bug label Aug 5, 2019

@dahlia dahlia added this to the 0.5.0 milestone Aug 5, 2019

@dahlia dahlia requested review from longfin, earlbread and moreal Aug 5, 2019

@dahlia dahlia self-assigned this Aug 5, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 5, 2019

Codecov Report

Merging #398 into 9c-fft will increase coverage by 8%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           9c-fft     #398      +/-   ##
==========================================
+ Coverage   80.17%   88.17%      +8%     
==========================================
  Files          61      193     +132     
  Lines        1513    13736   +12223     
==========================================
+ Hits         1213    12112   +10899     
- Misses        271     1335    +1064     
- Partials       29      289     +260
Impacted Files Coverage Δ
Libplanet/Store/LiteDBStore.cs 90.88% <100%> (ø)
Libplanet.Tests/Store/LiteDBStoreTest.cs 96.42% <100%> (ø)
Libplanet/Net/Messages/BlockHashes.cs 100% <0%> (ø)
Libplanet/Net/NoSwarmContextException.cs 0% <0%> (ø)
Libplanet.Tests/Action/ActionEvaluationTest.cs 96.55% <0%> (ø)
Libplanet.Tests/Store/StoreTest.cs 98.83% <0%> (ø)
Libplanet.Tests/Store/FileStoreTest.cs 100% <0%> (ø)
Libplanet/Blocks/Block.cs 86.38% <0%> (ø)
Libplanet/Net/PeerSetDelta.cs 85.36% <0%> (ø)
...planet/Blockchain/Policies/BlockPolicyExtension.cs 100% <0%> (ø)
... and 124 more
CHANGES.md Outdated Show resolved Hide resolved
Libplanet.Tests/Store/LiteDBStoreTest.cs Show resolved Hide resolved
Libplanet/Store/LiteDBStore.cs Show resolved Hide resolved
Libplanet/Store/LiteDBStore.cs Outdated Show resolved Hide resolved

@dahlia dahlia force-pushed the dahlia:litedb-state-refs branch from 1baadf8 to 338cf86 Aug 6, 2019

@dahlia dahlia force-pushed the dahlia:litedb-state-refs branch from 338cf86 to 8df25b3 Aug 6, 2019

@dahlia dahlia requested a review from earlbread Aug 6, 2019

@moreal
moreal approved these changes Aug 6, 2019
@longfin
longfin approved these changes Aug 6, 2019

@dahlia dahlia merged commit 5183aba into planetarium:9c-fft Aug 6, 2019

16 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 80.17%)
Details
codecov/project 88.17% (+8%) compared to 453f3e5
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190806.4 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.