Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report total block download status #399

Merged
merged 4 commits into from Aug 6, 2019

Conversation

@earlbread
Copy link
Member

commented Aug 5, 2019

This makes PreloadAsync report total block download status instead of chunked download status.

Resolves #396.

@earlbread earlbread requested review from dahlia and longfin Aug 5, 2019

@earlbread earlbread self-assigned this Aug 5, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 5, 2019

Codecov Report

Merging #399 into 9c-fft will decrease coverage by 0.01%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           9c-fft     #399      +/-   ##
==========================================
- Coverage   88.17%   88.16%   -0.02%     
==========================================
  Files         193      193              
  Lines       13736    13744       +8     
==========================================
+ Hits        12112    12117       +5     
  Misses       1335     1335              
- Partials      289      292       +3
Impacted Files Coverage Δ
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.3% <100%> (ø) ⬆️
Libplanet/Blockchain/BlockChain.cs 95.51% <100%> (+0.01%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 93.59% <100%> (ø) ⬆️
Libplanet/Net/BlockDownloadState.cs 100% <100%> (ø) ⬆️
Libplanet/Net/Swarm.cs 78.73% <70%> (-0.14%) ⬇️
@earlbread

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

I fixed tests to test the total block count. Please take a look.

@earlbread earlbread requested a review from longfin Aug 6, 2019

CHANGES.md Outdated Show resolved Hide resolved
{
int count = FindNextHashesChunkSize;

This comment has been minimized.

Copy link
@dahlia

dahlia Aug 6, 2019

Member

So, is it basically for unit tests?

This comment has been minimized.

Copy link
@earlbread

earlbread Aug 6, 2019

Author Member

Right, it's for unit tests.

@earlbread earlbread requested a review from dahlia Aug 6, 2019

@earlbread earlbread force-pushed the earlbread:total-block-progress branch from 6008ba3 to a017685 Aug 6, 2019

@earlbread earlbread requested review from dahlia and longfin Aug 6, 2019

Add description for internal property
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
Reword docs
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
@dahlia
dahlia approved these changes Aug 6, 2019

@earlbread earlbread merged commit cc5a56e into planetarium:9c-fft Aug 6, 2019

15 of 16 checks passed

codecov/patch 82.35% of diff hit (target 88.17%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 88.16% (-0.02%) compared to 5183aba
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190806.10 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details

@earlbread earlbread deleted the earlbread:total-block-progress branch Aug 6, 2019

moreal added a commit to moreal/libplanet that referenced this pull request Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.