Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make swarm report more progresses during preload #400

Merged

Conversation

@moreal
Copy link
Contributor

commented Aug 6, 2019

It resolves #397.

Before this, there was no way to know progress of download state-references or block-states.
So this make swarm report progress with State classes inherited PreloadState during preload. 馃悎

@codecov

This comment has been minimized.

Copy link

commented Aug 6, 2019

Codecov Report

Merging #400 into master will decrease coverage by 0.11%.
The diff coverage is 58%.

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   88.19%   88.07%   -0.12%     
==========================================
  Files         195      198       +3     
  Lines       13955    14001      +46     
==========================================
+ Hits        12307    12332      +25     
- Misses       1354     1362       +8     
- Partials      294      307      +13
Impacted Files Coverage 螖
Libplanet/Net/StateReferenceDownloadState.cs 0% <0%> (酶)
Libplanet/Net/BlockStateDownloadState.cs 0% <0%> (酶)
Libplanet.Tests/Net/SwarmTest.cs 93.76% <100%> (+0.04%) 猬嗭笍
Libplanet/Net/BlockDownloadState.cs 100% <100%> (酶) 猬嗭笍
Libplanet/Net/ActionExecutionState.cs 100% <100%> (酶)
Libplanet/Net/Swarm.cs 78.23% <50%> (-0.52%) 猬囷笍

@moreal moreal self-assigned this Aug 6, 2019

@moreal moreal changed the base branch from master to 9c-fft Aug 6, 2019

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Libplanet/Net/BlockEvaluationState.cs Outdated Show resolved Hide resolved
Libplanet/Net/BlockStateDownloadState.cs Show resolved Hide resolved
Libplanet/Net/PreloadState.cs Outdated Show resolved Hide resolved
Libplanet/Net/StateReferenceDownloadState.cs Outdated Show resolved Hide resolved
Libplanet/Net/StateReferenceDownloadState.cs Outdated Show resolved Hide resolved
Libplanet/Net/PreloadState.cs Outdated Show resolved Hide resolved
Libplanet/Net/PreloadState.cs Outdated Show resolved Hide resolved
Libplanet/Net/PreloadState.cs Outdated Show resolved Hide resolved

@moreal moreal force-pushed the moreal:implement-more-progresses-during-preload-397 branch from 79b5e5a to 11adab6 Aug 6, 2019

@moreal moreal closed this Aug 6, 2019

@moreal moreal force-pushed the moreal:implement-more-progresses-during-preload-397 branch from 11adab6 to cc5a56e Aug 6, 2019

@moreal moreal reopened this Aug 6, 2019

@moreal moreal force-pushed the moreal:implement-more-progresses-during-preload-397 branch 2 times, most recently from 4b1b752 to d4d2ec0 Aug 6, 2019

@moreal moreal changed the base branch from 9c-fft to master Aug 6, 2019

@moreal moreal force-pushed the moreal:implement-more-progresses-during-preload-397 branch 2 times, most recently from cceadd2 to 2bdffe4 Aug 6, 2019

@moreal moreal requested a review from dahlia Aug 6, 2019

@moreal moreal marked this pull request as ready for review Aug 6, 2019

@moreal moreal force-pushed the moreal:implement-more-progresses-during-preload-397 branch 3 times, most recently from 54c5f0c to 4523277 Aug 6, 2019

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Libplanet/Net/ActionExecutionState.cs Outdated Show resolved Hide resolved
Libplanet/Net/BlockStateDownloadState.cs Outdated Show resolved Hide resolved
Libplanet/Net/BlockStateDownloadState.cs Outdated Show resolved Hide resolved
Libplanet/Net/PreloadState.cs Outdated Show resolved Hide resolved
Libplanet/Net/PreloadState.cs Outdated Show resolved Hide resolved
Libplanet/Net/PreloadState.cs Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Libplanet/Net/PreloadState.cs Outdated Show resolved Hide resolved

@moreal moreal force-pushed the moreal:implement-more-progresses-during-preload-397 branch from 35c17a9 to 9f47b44 Aug 7, 2019

@moreal moreal force-pushed the moreal:implement-more-progresses-during-preload-397 branch 3 times, most recently from 43db9e8 to 9431070 Aug 7, 2019

@moreal moreal requested review from longfin and earlbread Aug 7, 2019

@moreal moreal added this to the 0.5.0 milestone Aug 7, 2019

Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved

@moreal moreal dismissed stale reviews from dahlia and dahlia via 11721ed Aug 8, 2019

moreal and others added 8 commits Aug 6, 2019

@moreal moreal force-pushed the moreal:implement-more-progresses-during-preload-397 branch from 11721ed to 418d51d Aug 8, 2019

@longfin
longfin approved these changes Aug 8, 2019

@longfin longfin requested a review from dahlia Aug 8, 2019

@dahlia
dahlia approved these changes Aug 8, 2019

@moreal moreal merged commit b3540b4 into planetarium:master Aug 8, 2019

16 of 17 checks passed

codecov/patch 58% of diff hit (target 88.19%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 88.07% (-0.12%) compared to 3c4ffea
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190808.3 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.