Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply timeout to receving BlockHashes, Blocks and Tx #416

Merged
merged 2 commits into from Aug 9, 2019

Conversation

@longfin
Copy link
Member

commented Aug 8, 2019

This PR apply a timeout to Message.GetBlockBlockHash, Message.GetBlocks and Message.Tx to avoid hanging when a remote peer had gone.

@longfin longfin force-pushed the longfin:bugfix/swarm-hang branch from dbfb470 to 886cea0 Aug 8, 2019

@longfin longfin changed the title Apply timeout to GetBlockHashes, GetBlocks and Tx Apply timeout to BlockHashes, Blocks and Tx Aug 8, 2019

@longfin longfin requested review from dahlia, earlbread, limebell and moreal Aug 8, 2019

@longfin longfin changed the title Apply timeout to BlockHashes, Blocks and Tx Apply timeout to receving BlockHashes, Blocks and Tx Aug 8, 2019

@longfin longfin marked this pull request as ready for review Aug 8, 2019

CHANGES.md Outdated Show resolved Hide resolved

@longfin longfin dismissed stale reviews from limebell, earlbread, limebell, and earlbread via 8812046 Aug 8, 2019

@longfin longfin force-pushed the longfin:bugfix/swarm-hang branch from 8812046 to 48240ea Aug 8, 2019

@longfin longfin requested review from dahlia, moreal, earlbread and limebell Aug 8, 2019

CHANGES.md Outdated Show resolved Hide resolved

@longfin longfin dismissed stale reviews from limebell, earlbread, moreal, and limebell via 078deb9 Aug 8, 2019

@longfin longfin dismissed stale reviews from earlbread and moreal via 078deb9 Aug 8, 2019

@longfin longfin requested a review from dahlia Aug 8, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 8, 2019

Codecov Report

Merging #416 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
+ Coverage   88.04%   88.12%   +0.08%     
==========================================
  Files         198      198              
  Lines       14061    14067       +6     
==========================================
+ Hits        12380    12397      +17     
+ Misses       1370     1358      -12     
- Partials      311      312       +1
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 78.39% <100%> (+0.08%) ⬆️
Libplanet/Crypto/PrivateKey.cs 84.68% <0%> (-0.91%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 94.23% <0%> (+1.28%) ⬆️

@longfin longfin dismissed stale reviews from dahlia and earlbread via e8b5a12 Aug 8, 2019

@longfin longfin self-assigned this Aug 8, 2019

@longfin longfin force-pushed the longfin:bugfix/swarm-hang branch from e8b5a12 to 5d46406 Aug 8, 2019

longfin and others added 2 commits Aug 8, 2019
Update CHANGES.md
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>

@longfin longfin force-pushed the longfin:bugfix/swarm-hang branch from 5d46406 to 1d4cd73 Aug 8, 2019

@longfin longfin requested review from dahlia, moreal and limebell Aug 9, 2019

@moreal
moreal approved these changes Aug 9, 2019
@dahlia
dahlia approved these changes Aug 9, 2019

@longfin longfin merged commit 69869ef into planetarium:master Aug 9, 2019

17 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 88.04%)
Details
codecov/project 88.12% (+0.08%) compared to 5720096
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190808.26 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.