Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure preloaded data recorded all or nothing #417

Merged
merged 2 commits into from Aug 8, 2019

Conversation

@dahlia
Copy link
Member

commented Aug 8, 2019

No description provided.

@dahlia dahlia added the bug label Aug 8, 2019

@dahlia dahlia added this to the 0.5.0 milestone Aug 8, 2019

@dahlia dahlia requested review from longfin and earlbread Aug 8, 2019

@dahlia dahlia self-assigned this Aug 8, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 8, 2019

Codecov Report

Merging #417 into master will increase coverage by 0.03%.
The diff coverage is 85%.

@@            Coverage Diff            @@
##           master    #417      +/-   ##
=========================================
+ Coverage   88.06%   88.1%   +0.03%     
=========================================
  Files         198     198              
  Lines       14006   14061      +55     
=========================================
+ Hits        12335   12389      +54     
+ Misses       1364    1361       -3     
- Partials      307     311       +4
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 78.3% <75%> (+0.24%) ⬆️
Libplanet/Blockchain/BlockChain.cs 94.91% <84.61%> (ø) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 93.91% <97.43%> (+0.14%) ⬆️

@dahlia dahlia requested a review from earlbread Aug 8, 2019

@longfin
longfin approved these changes Aug 8, 2019

@dahlia dahlia merged commit 5720096 into planetarium:master Aug 8, 2019

16 of 17 checks passed

codecov/patch 85% of diff hit (target 88.06%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 88.1% (+0.03%) compared to dc14431
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190808.21 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.