Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue RefreshAllocate and RefreshPermission even if exc occurred. #422

Merged
merged 2 commits into from Aug 13, 2019

Conversation

@longfin
Copy link
Member

commented Aug 11, 2019

This PR fixes a bug that Swarm<T> hadn't retried TURN related methods automatically when an exception occurred.

@longfin longfin force-pushed the longfin:bugfix/exc-in-turn branch from 438d844 to cdf6e95 Aug 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 11, 2019

Codecov Report

Merging #422 into master will decrease coverage by 0.3%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   88.24%   87.93%   -0.31%     
==========================================
  Files         198      198              
  Lines       14381    14410      +29     
==========================================
- Hits        12691    12672      -19     
- Misses       1376     1424      +48     
  Partials      314      314
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 77.96% <0%> (-1.97%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 91.52% <0%> (-1.23%) ⬇️

@longfin longfin self-assigned this Aug 12, 2019

@longfin longfin force-pushed the longfin:bugfix/exc-in-turn branch 3 times, most recently from d5f88be to f9d0eab Aug 12, 2019

@longfin longfin force-pushed the longfin:bugfix/exc-in-turn branch from f9d0eab to 732ddfb Aug 13, 2019

@longfin longfin requested review from dahlia and earlbread and removed request for dahlia Aug 13, 2019

@longfin longfin marked this pull request as ready for review Aug 13, 2019

CHANGES.md Outdated Show resolved Hide resolved
Update CHANGES.md
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>

@longfin longfin dismissed stale reviews from dahlia and earlbread via b7cd3ba Aug 13, 2019

@longfin longfin requested review from dahlia and earlbread Aug 13, 2019

@dahlia
dahlia approved these changes Aug 13, 2019

@earlbread earlbread merged commit c95530a into planetarium:master Aug 13, 2019

16 of 17 checks passed

codecov/patch 0% of diff hit (target 88.24%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 87.93% (-0.31%) compared to c00523d
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190813.28 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.