Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit branch point finding when render=false #423

Merged

Conversation

@longfin
Copy link
Member

commented Aug 11, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

commented Aug 11, 2019

Codecov Report

Merging #423 into master will increase coverage by 0.06%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   88.09%   88.16%   +0.06%     
==========================================
  Files         198      198              
  Lines       14365    14365              
==========================================
+ Hits        12655    12665      +10     
+ Misses       1398     1387      -11     
- Partials      312      313       +1
Impacted Files Coverage Δ
Libplanet/Blockchain/BlockChain.cs 94.95% <0%> (-0.16%) ⬇️
Libplanet/Net/Swarm.cs 79.31% <0%> (+0.46%) ⬆️
Libplanet/Store/BaseIndex.cs 37.03% <0%> (+7.4%) ⬆️

@longfin longfin force-pushed the longfin:feature/omit-branchpoint-finding branch from f505ff8 to 81f49ce Aug 11, 2019

@longfin longfin requested review from dahlia, earlbread, moreal and limebell Aug 12, 2019

@longfin longfin marked this pull request as ready for review Aug 12, 2019

@longfin longfin self-assigned this Aug 12, 2019

@longfin longfin dismissed stale reviews from earlbread and dahlia via 740c85d Aug 12, 2019

@longfin longfin force-pushed the longfin:feature/omit-branchpoint-finding branch from 81f49ce to 740c85d Aug 12, 2019

@longfin longfin force-pushed the longfin:feature/omit-branchpoint-finding branch from 740c85d to 85eb464 Aug 13, 2019

@moreal
moreal approved these changes Aug 13, 2019

@longfin longfin requested review from dahlia and limebell Aug 13, 2019

@dahlia
dahlia approved these changes Aug 13, 2019

@longfin longfin merged commit 2a7df0d into planetarium:master Aug 13, 2019

16 of 17 checks passed

codecov/patch 0% of diff hit (target 88.09%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 88.16% (+0.06%) compared to 6fc51cd
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190813.8 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.