Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-ordering Swarm<T>.StartAsync() #424

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@longfin
Copy link
Member

commented Aug 11, 2019

This PR adjusts the order of processes in Swarm<T>.StartAsync() to avoid disabling TURN allocation even if Swarm<T>.PreloadAsync() takes a long time.

Re-ordering Swarm<T>.StartAsync()
- Listen → (NAT check & set Endpoint & run TURN tasks) → preload → run & wait other tasks (+1 squashed commits)

@longfin longfin force-pushed the longfin:feature/reorder-startasync branch from 4e14fd6 to 8962f5e Aug 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 11, 2019

Codecov Report

Merging #424 into master will increase coverage by 0.05%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   88.16%   88.22%   +0.05%     
==========================================
  Files         198      198              
  Lines       14230    14221       -9     
==========================================
  Hits        12546    12546              
+ Misses       1373     1364       -9     
  Partials      311      311
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 78.91% <76.19%> (+0.48%) ⬆️

@longfin longfin marked this pull request as ready for review Aug 12, 2019

@longfin longfin requested review from dahlia, earlbread, limebell and moreal and removed request for dahlia Aug 12, 2019

@dahlia
dahlia approved these changes Aug 12, 2019

@longfin longfin merged commit 0287ac9 into planetarium:master Aug 12, 2019

16 of 17 checks passed

codecov/patch 76.19% of diff hit (target 88.16%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 88.22% (+0.05%) compared to 699e3ac
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190811.4 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.