Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonical namespace explicitly stored #426

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@limebell
Copy link
Contributor

commented Aug 12, 2019

No description provided.

@limebell limebell requested review from longfin and earlbread Aug 12, 2019

@limebell limebell self-assigned this Aug 12, 2019

@limebell limebell added the bug label Aug 12, 2019

@limebell limebell added this to the 0.5.0 milestone Aug 12, 2019

@limebell limebell force-pushed the limebell:canonical-namespace branch from 9e75d06 to 36f083b Aug 12, 2019

CHANGES.md Outdated Show resolved Hide resolved

@limebell limebell force-pushed the limebell:canonical-namespace branch from 36f083b to a86f175 Aug 12, 2019

limebell and others added 2 commits Aug 12, 2019
Get/set canonical namespace on IStore
Co-authored-by: Hong Minhee <hong.minhee@gmail.com>
Explicitly store canonical chain
Co-authored-by: Hong Minhee <hong.minhee@gmail.com>

@limebell limebell force-pushed the limebell:canonical-namespace branch from a86f175 to 29749c0 Aug 12, 2019

@limebell limebell requested a review from longfin Aug 12, 2019

@dahlia dahlia merged commit cd96e75 into planetarium:master Aug 12, 2019

15 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190812.7 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.