Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swarm test preload fails #431

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@moreal
Copy link
Contributor

commented Aug 13, 2019

It resolves #430
The states may be reported not in sorted.
So I changed the part to assert.

@moreal moreal force-pushed the moreal:fix-swarm-test-preload-fails branch from 5e89c5c to 5e98eba Aug 13, 2019

@moreal moreal self-assigned this Aug 13, 2019

@moreal moreal added the bug label Aug 13, 2019

@moreal moreal force-pushed the moreal:fix-swarm-test-preload-fails branch from 5e98eba to 47aec5a Aug 13, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 13, 2019

Codecov Report

Merging #431 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
- Coverage   87.95%   87.94%   -0.01%     
==========================================
  Files         198      198              
  Lines       14425    14426       +1     
==========================================
  Hits        12687    12687              
- Misses       1424     1425       +1     
  Partials      314      314
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 78% <ø> (ø) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 92.34% <100%> (-0.1%) ⬇️

@moreal moreal force-pushed the moreal:fix-swarm-test-preload-fails branch 6 times, most recently from 7632e60 to f92dff6 Aug 13, 2019

@moreal moreal force-pushed the moreal:fix-swarm-test-preload-fails branch from f92dff6 to 902625b Aug 14, 2019

@moreal moreal marked this pull request as ready for review Aug 14, 2019

@moreal moreal requested review from dahlia, longfin and earlbread Aug 14, 2019

@dahlia

dahlia approved these changes Aug 14, 2019

@longfin longfin merged commit b41da29 into planetarium:master Aug 14, 2019

17 checks passed

WIP Ready for review
Details
changelog Check was skipped.
Details
codecov/patch 100% of diff hit (target 87.95%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +12.04% compared to af529f4
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190814.13 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.