Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readOnly option to LiteDBStore #434

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@longfin
Copy link
Member

commented Aug 13, 2019

No description provided.

@longfin longfin changed the title Adds readOnly option to LiteDBStore Add readOnly option to LiteDBStore Aug 13, 2019

@dahlia

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Is it needed for running an explorer instance?

@longfin longfin force-pushed the longfin:feature/litedb-readonly branch from b55e420 to 7d8670d Aug 13, 2019

@longfin

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

Is it need for running an explorer instance?

Yes, it's intended to be used by read-only instance like block explorer.

@longfin longfin marked this pull request as ready for review Aug 13, 2019

@longfin longfin requested a review from dahlia Aug 13, 2019

@dahlia

dahlia approved these changes Aug 13, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 13, 2019

Codecov Report

Merging #434 into master will decrease coverage by 0.02%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   87.99%   87.97%   -0.03%     
==========================================
  Files         198      198              
  Lines       14413    14418       +5     
==========================================
+ Hits        12683    12684       +1     
- Misses       1416     1419       +3     
- Partials      314      315       +1
Impacted Files Coverage Δ
Libplanet/Store/LiteDBStore.cs 89.16% <42.85%> (-0.63%) ⬇️
Libplanet/Crypto/PrivateKey.cs 84.68% <0%> (-0.91%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 92.33% <0%> (-0.11%) ⬇️
Libplanet/Net/Swarm.cs 78% <0%> (+0.06%) ⬆️

@longfin longfin merged commit 2fe236d into planetarium:master Aug 13, 2019

16 of 17 checks passed

codecov/patch 42.85% of diff hit (target 87.99%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 87.97% (-0.03%) compared to 993d9c3
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190813.41 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.