Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement deterministic Guid #439

Merged
merged 2 commits into from Aug 16, 2019

Conversation

@ipdae
Copy link
Member

commented Aug 15, 2019

resolved #371

@codecov

This comment has been minimized.

Copy link

commented Aug 15, 2019

Codecov Report

Merging #439 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
+ Coverage   87.97%   87.97%   +<.01%     
==========================================
  Files         198      198              
  Lines       14443    14489      +46     
==========================================
+ Hits        12706    12747      +41     
- Misses       1422     1426       +4     
- Partials      315      316       +1
Impacted Files Coverage Δ
Libplanet/Action/ActionContext.cs 100% <100%> (ø) ⬆️
Libplanet.Tests/Action/ActionContextTest.cs 89.7% <100%> (+15.63%) ⬆️
Libplanet/Crypto/PrivateKey.cs 85.34% <0%> (-0.87%) ⬇️
Libplanet/Net/Swarm.cs 77.8% <0%> (-0.46%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 92.65% <0%> (+0.3%) ⬆️
Libplanet/Action/ActionContext.cs Outdated Show resolved Hide resolved
{
(0, new Guid("6f460c1a-755d-d8e4-ad67-65d5f519dbc8")),
(1, new Guid("8286d046-9740-a3e4-95cf-ff46699c73c4")),
};

This comment has been minimized.

Copy link
@earlbread

earlbread Aug 15, 2019

Member

How about using InlineData?

@@ -53,5 +55,7 @@ public interface IActionContext
/// <returns>A random object that shares interface mostly equivalent
/// to <see cref="System.Random"/>.</returns>
IRandom Random { get; }

Guid Guid { get; }

This comment has been minimized.

Copy link
@earlbread

earlbread Aug 15, 2019

Member

Could you please add documentation?

@ipdae ipdae force-pushed the ipdae:issues-371 branch from 993d115 to c50fd59 Aug 15, 2019

@ipdae ipdae force-pushed the ipdae:issues-371 branch from c50fd59 to e989795 Aug 15, 2019

@longfin longfin added this to In progress in PyCon Korea 2019 via automation Aug 15, 2019

@ipdae ipdae force-pushed the ipdae:issues-371 branch from b192bf3 to e32bd41 Aug 15, 2019

@earlbread earlbread requested a review from dahlia Aug 15, 2019

CHANGES.md Outdated Show resolved Hide resolved

@ipdae ipdae dismissed stale reviews from longfin and earlbread via 51b0544 Aug 15, 2019

@dahlia dahlia dismissed stale reviews from earlbread and themself via e68b2b9 Aug 16, 2019

@dahlia dahlia force-pushed the ipdae:issues-371 branch from 51b0544 to e68b2b9 Aug 16, 2019

@dahlia dahlia requested review from longfin, earlbread and moreal Aug 16, 2019

@dahlia
dahlia approved these changes Aug 16, 2019
Copy link
Member

left a comment

@earlbread @longfin @moreal I rebased it on the current master. Please review this again.

@moreal
moreal approved these changes Aug 16, 2019

@dahlia dahlia merged commit f46dfd6 into planetarium:master Aug 16, 2019

17 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 87.97%)
Details
codecov/project 87.97% (+<.01%) compared to 52e9107
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190816.2 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details

PyCon Korea 2019 automation moved this from In progress to Done Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.