Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less stateful RawTransaction #441

Merged
merged 1 commit into from Aug 21, 2019
Merged

Conversation

minhoryang
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #441 into master will increase coverage by 0.1%.
The diff coverage is 93.42%.

@@            Coverage Diff            @@
##           master     #441     +/-   ##
=========================================
+ Coverage   87.76%   87.87%   +0.1%     
=========================================
  Files         195      195             
  Lines       13669    13686     +17     
=========================================
+ Hits        11997    12026     +29     
+ Misses       1360     1348     -12     
  Partials      312      312
Impacted Files Coverage Δ
Libplanet.Tests/Blocks/BlockTest.cs 98.02% <100%> (ø) ⬆️
Libplanet.Tests/Tx/TransactionTest.cs 92.71% <100%> (ø) ⬆️
Libplanet/Tx/Transaction.cs 95.73% <100%> (ø) ⬆️
Libplanet/Tx/RawTransaction.cs 84.67% <89.13%> (+2.17%) ⬆️
Libplanet/Net/Swarm.cs 79.16% <0%> (+0.19%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 92.34% <0%> (+0.91%) ⬆️

@minhoryang
Copy link
Contributor Author

minhoryang commented Aug 15, 2019

TestFailed Diagnosis:

  • Linux_NETCore, macOS_NETCore : flaky maybe.
  • macOS_Unity : flaky. return 0 with following cmd:
    ../StandaloneOSX.app/Contents/MacOS/StandaloneOSX "$(pwd)"/./Libplanet.Tests/bin/Debug/net461/Libplanet.Tests.dll "$(pwd)"/./Libplanet.Stun.Tests/bin/Debug/net461/Libplanet.Stun.Tests.dll "$(pwd)"/./Libplanet.Benchmarks/bin/Debug/net461/Libplanet.Tests.dll
    

limebell
limebell previously approved these changes Aug 16, 2019
Libplanet/Tx/Transaction.cs Outdated Show resolved Hide resolved
@minhoryang minhoryang changed the title [WIP] Resolves #172, Signer is now ImmutableArray<byte> Less stateful RawTransaction Aug 16, 2019
@minhoryang minhoryang marked this pull request as ready for review August 16, 2019 17:32
CHANGES.md Outdated Show resolved Hide resolved
Libplanet/Tx/Transaction.cs Outdated Show resolved Hide resolved
Libplanet/Tx/RawTransaction.cs Outdated Show resolved Hide resolved
moreal
moreal previously approved these changes Aug 21, 2019
@earlbread
Copy link
Contributor

earlbread commented Aug 21, 2019

Could you rebase it on the current master instead of merging the master to avoid cross-merging between upstream and downstream? @minhoryang

longfin
longfin previously approved these changes Aug 21, 2019
@minhoryang
Copy link
Contributor Author

minhoryang commented Aug 21, 2019

@earlbread Yes, I'll rebase this branch, test locally and force-push it.

@longfin longfin merged commit aa3b376 into planetarium:master Aug 21, 2019
@longfin
Copy link
Member

longfin commented Aug 21, 2019

@minhoryang Thanks for the patch! 🎉

@minhoryang
Copy link
Contributor Author

Thanks all for kindly reviewing my patchset and supporting at the #pyconkr19 sprint!
It's honor to be here with you guys!

@minhoryang minhoryang deleted the issues/172 branch August 21, 2019 15:02
limebell pushed a commit to limebell/libplanet that referenced this pull request Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants