Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Address(ImmutableArray<byte>) constructor #443

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@kanghyojun
Copy link
Contributor

commented Aug 16, 2019

  • Resolve #442
  • Address(byte[]) became to throw ArgumentNullException
    instead of NullReferenceException.
@CLAassistant

This comment has been minimized.

Copy link

commented Aug 16, 2019

CLA assistant check
All committers have signed the CLA.

@dahlia dahlia added this to In progress in PyCon Korea 2019 via automation Aug 16, 2019

CHANGES.md Outdated
@@ -29,6 +29,8 @@ To be released.
- Removed `IRandom.NextDouble()` method, because [floating-point arithmetics,
which is underspecified, likely introduce
indeterminism][floating-point determinism]. [[#410], [#419]]
- `Address(byte[])` became to throw `ArgumentNullException`
instead of `NullReferenceException`. [[#442], [#443]]

This comment has been minimized.

Copy link
@longfin

longfin Aug 16, 2019

Member

Actually, #442 doesn't seem to address it.

Suggested change
instead of `NullReferenceException`. [[#442], [#443]]
instead of `NullReferenceException`. [[#443]]
/// <see cref="Address"/> can be gotten using <see cref="ToByteArray()"
/// /> method.</remarks>
/// <seealso cref="ByteArray"/>
public Address(ImmutableArray<byte> address) {

This comment has been minimized.

Copy link
@moreal

moreal Aug 16, 2019

Contributor
Suggested change
public Address(ImmutableArray<byte> address) {
public Address(ImmutableArray<byte> address)
{
Libplanet/Address.cs Outdated Show resolved Hide resolved

@kanghyojun kanghyojun force-pushed the kanghyojun:address-cosntructor branch from 217e5c3 to 353c99c Aug 16, 2019

@kanghyojun kanghyojun marked this pull request as ready for review Aug 16, 2019

@kanghyojun kanghyojun force-pushed the kanghyojun:address-cosntructor branch from 353c99c to 2708166 Aug 16, 2019

@dahlia dahlia requested review from longfin, moreal and earlbread Aug 16, 2019

@dahlia
dahlia approved these changes Aug 16, 2019
@moreal
moreal approved these changes Aug 16, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 16, 2019

Codecov Report

Merging #443 into master will decrease coverage by 4.43%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
- Coverage   87.99%   83.56%   -4.44%     
==========================================
  Files         198      174      -24     
  Lines       14489    13820     -669     
==========================================
- Hits        12750    11549    -1201     
- Misses       1424     1985     +561     
+ Partials      315      286      -29
Impacted Files Coverage Δ
Libplanet/Address.cs 93.33% <100%> (ø) ⬆️
Libplanet.Tests/AddressTest.cs 95.87% <100%> (+0.24%) ⬆️
Libplanet.Stun/Stun/Attributes/ErrorCode.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Attributes/Lifetime.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Attributes/Nonce.cs 0% <0%> (-100%) ⬇️
...anet.Stun/Stun/Messages/CreatePermissionRequest.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Messages/BindingRequest.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Attributes/Realm.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Attributes/Fingerprint.cs 0% <0%> (-100%) ⬇️
...planet.Stun/Stun/Messages/ConnectionBindRequest.cs 0% <0%> (-100%) ⬇️
... and 45 more

@longfin longfin merged commit b1cb141 into planetarium:master Aug 16, 2019

17 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 87.99%)
Details
codecov/project Absolute coverage decreased by -4.43% but relative coverage increased by +12% compared to f46dfd6
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190816.4 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details

PyCon Korea 2019 automation moved this from In progress to Done Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
6 participants
You can’t perform that action at this time.