Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct GetBlockHashes chunk size after first phase #445

Merged
merged 1 commit into from Aug 17, 2019

Conversation

@gurrpi
Copy link
Contributor

commented Aug 16, 2019

This PR fixes behavior of peer—which responses getBlockHashes()—to contains one more higher block hash for satisfy FindNextHashesChunkSize (Since the peer which performs PreloadAsync() drops the lowest block from the response of getBlockHashes() except initial phase).

Resolves #408.

@CLAassistant

This comment has been minimized.

Copy link

commented Aug 16, 2019

CLA assistant check
All committers have signed the CLA.

@codecov

This comment has been minimized.

Copy link

commented Aug 16, 2019

Codecov Report

Merging #445 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #445      +/-   ##
=========================================
+ Coverage   88.02%   88.1%   +0.07%     
=========================================
  Files         198     198              
  Lines       14501   14505       +4     
=========================================
+ Hits        12764   12779      +15     
+ Misses       1422    1411      -11     
  Partials      315     315
Impacted Files Coverage Δ
Libplanet/Blockchain/BlockChain.cs 94.53% <100%> (+0.03%) ⬆️
Libplanet/Net/Swarm.cs 77.61% <0%> (-0.46%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 94.08% <0%> (+1.42%) ⬆️
Libplanet.Tests/Store/FileStoreFixture.cs 100% <0%> (+19.04%) ⬆️
CHANGES.md Outdated Show resolved Hide resolved

@gurrpi gurrpi force-pushed the gurrpi:issues/408 branch from 4b3c1ac to d4e866e Aug 16, 2019

@dahlia
dahlia approved these changes Aug 16, 2019
@longfin
Copy link
Member

left a comment

👍

@longfin longfin merged commit 7375170 into planetarium:master Aug 17, 2019

17 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 88.02%)
Details
codecov/project 88.1% (+0.07%) compared to b1cb141
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190816.13 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details

@gurrpi gurrpi deleted the gurrpi:issues/408 branch Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.