Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FileStore #446

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@longfin
Copy link
Member

commented Aug 19, 2019

This PR removes FileStore implementation because it is difficult to maintain continuously.

@longfin longfin force-pushed the longfin:feature/remove-filestore branch from 871d7ad to ee8278f Aug 19, 2019

@longfin longfin force-pushed the longfin:feature/remove-filestore branch from ee8278f to 5036107 Aug 19, 2019

@longfin longfin requested review from dahlia, earlbread, limebell and moreal Aug 19, 2019

@longfin longfin marked this pull request as ready for review Aug 19, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 19, 2019

Codecov Report

Merging #446 into master will decrease coverage by 0.27%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
- Coverage   88.14%   87.87%   -0.28%     
==========================================
  Files         198      195       -3     
  Lines       14505    13669     -836     
==========================================
- Hits        12785    12011     -774     
+ Misses       1405     1346      -59     
+ Partials      315      312       -3
Impacted Files Coverage Δ
Libplanet.Tests/Store/StoreFixture.cs 100% <ø> (ø) ⬆️
Libplanet.Tests/Store/LiteDBStoreFixture.cs 91.66% <ø> (ø) ⬆️
...lanet.Tests/Blockchain/Policies/BlockPolicyTest.cs 98.7% <ø> (ø) ⬆️
Libplanet.Tests/Store/StoreExtensionTest.cs 100% <ø> (ø) ⬆️
Libplanet.Tests/Store/TransactionSetTest.cs 96.49% <100%> (ø) ⬆️
Libplanet.Tests/Store/StoreTrackerTest.cs 100% <100%> (ø) ⬆️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.4% <100%> (ø) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 92.44% <100%> (-1.64%) ⬇️
Libplanet.Tests/Store/BlockSetTest.cs 96.72% <100%> (ø) ⬆️
Libplanet/Store/BaseStore.cs 81.25% <0%> (-18.75%) ⬇️
... and 2 more
@dahlia
dahlia approved these changes Aug 19, 2019

@longfin longfin self-assigned this Aug 19, 2019

@longfin longfin merged commit 3ec8619 into planetarium:master Aug 19, 2019

17 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 88.14%)
Details
codecov/project Absolute coverage decreased by -0.27% but relative coverage increased by +11.85% compared to 7375170
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190819.5 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.