Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArgumentNullException thrown by BlockChain<T>.Fork() where it has incomplete states #466

Merged

Conversation

@dahlia
Copy link
Member

commented Aug 27, 2019

This fixes #454. I'm going to make another patch to remove the addressesToStrip parameter at all from IStore.ForkStateReferences() method (see also FIXME comment) to the master branch.

@dahlia dahlia added the bug label Aug 27, 2019

@dahlia dahlia requested review from longfin, limebell, earlbread and moreal Aug 27, 2019

@dahlia dahlia self-assigned this Aug 27, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 27, 2019

Codecov Report

Merging #466 into 0.5-maintenance will increase coverage by 7.71%.
The diff coverage is 100%.

@@                 Coverage Diff                 @@
##           0.5-maintenance     #466      +/-   ##
===================================================
+ Coverage            80.17%   87.88%   +7.71%     
===================================================
  Files                   61      195     +134     
  Lines                 1513    13686   +12173     
===================================================
+ Hits                  1213    12028   +10815     
- Misses                 271     1346    +1075     
- Partials                29      312     +283
Impacted Files Coverage Δ
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.41% <100%> (ø)
Libplanet/Blockchain/BlockChain.cs 94.49% <100%> (ø)
Libplanet/Net/Messages/BlockHashes.cs 100% <0%> (ø)
Libplanet/Net/NoSwarmContextException.cs 0% <0%> (ø)
Libplanet.Tests/Action/ActionEvaluationTest.cs 96.66% <0%> (ø)
Libplanet.Tests/Store/StoreTest.cs 98.17% <0%> (ø)
Libplanet/Blocks/Block.cs 86.38% <0%> (ø)
Libplanet/Net/PeerSetDelta.cs 85.36% <0%> (ø)
...planet/Blockchain/Policies/BlockPolicyExtension.cs 100% <0%> (ø)
Libplanet/Blocks/InvalidBlockTimestampException.cs 100% <0%> (ø)
... and 126 more

@dahlia dahlia merged commit e8f8d39 into planetarium:0.5-maintenance Aug 27, 2019

16 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 80.17%)
Details
codecov/project 87.88% (+7.71%) compared to a158cfa
Details
docs Libplanet docs generated by DocFX
Details
planetarium.libplanet Build #20190827.6 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
dahlia added a commit to dahlia/libplanet that referenced this pull request Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.