Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary addressesToStrip parameter from IStore.ForkStateReferences() #467

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@dahlia
Copy link
Member

commented Aug 27, 2019

It's a port of the patch #466, and removes unnecessary addressesToStrip parameter from IStore.ForkStateReferences() method.

Fix #454
Port of #466
@dahlia dahlia added the bug label Aug 27, 2019
@dahlia dahlia added this to the 0.6.0 milestone Aug 27, 2019
@dahlia dahlia requested review from longfin, limebell, earlbread and moreal Aug 27, 2019
@dahlia dahlia self-assigned this Aug 27, 2019
@moreal
moreal approved these changes Aug 27, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 27, 2019

Codecov Report

Merging #467 into master will increase coverage by 0.14%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
+ Coverage   87.97%   88.12%   +0.14%     
==========================================
  Files         195      195              
  Lines       13729    13721       -8     
==========================================
+ Hits        12078    12091      +13     
+ Misses       1338     1318      -20     
+ Partials      313      312       -1
Impacted Files Coverage Δ
Libplanet/Store/BaseStore.cs 81.25% <ø> (ø) ⬆️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.41% <100%> (ø) ⬆️
Libplanet/Blockchain/BlockChain.cs 94.42% <100%> (-0.09%) ⬇️
Libplanet.Tests/Store/StoreTracker.cs 56.83% <100%> (+8.97%) ⬆️
Libplanet/Store/LiteDBStore.cs 89.33% <100%> (ø) ⬆️
Libplanet.Tests/Store/StoreTest.cs 98.41% <50%> (+0.17%) ⬆️
Libplanet/Net/Swarm.cs 80.25% <0%> (+0.25%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 92.65% <0%> (+0.3%) ⬆️
@dahlia dahlia merged commit a371911 into planetarium:master Aug 27, 2019
17 checks passed
17 checks passed
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 90% of diff hit (target 87.97%)
Details
codecov/project 88.12% (+0.14%) compared to e93f945
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190827.9 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.