Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all staged transactions broadcasted #470

Merged
merged 2 commits into from Aug 28, 2019

Conversation

@dahlia
Copy link
Member

commented Aug 27, 2019

Removed the concept of “staged transactions that should not be broadcasted,” because its primary usage had been to make a transaction of a reward action for a candidate for block miner, and the case became achieved through IBlockPolicy<T>.BlockAction property which was made by the patch #367.

So all staged transactions became broadcasted.

@dahlia dahlia added this to the 0.6.0 milestone Aug 27, 2019
@dahlia dahlia requested review from longfin, limebell, earlbread and moreal Aug 27, 2019
@dahlia dahlia self-assigned this Aug 27, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 27, 2019

Codecov Report

Merging #470 into master will decrease coverage by 0.05%.
The diff coverage is 97.29%.

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage    88.1%   88.04%   -0.06%     
==========================================
  Files         195      195              
  Lines       13721    13654      -67     
==========================================
- Hits        12089    12022      -67     
  Misses       1320     1320              
  Partials      312      312
Impacted Files Coverage Δ
Libplanet/Store/BaseStore.cs 81.25% <ø> (ø) ⬆️
Libplanet.Tests/Store/StoreTracker.cs 56.83% <0%> (ø) ⬆️
Libplanet/Net/Swarm.cs 80.24% <100%> (-0.02%) ⬇️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.4% <100%> (-0.02%) ⬇️
Libplanet/Blockchain/BlockChain.cs 94.4% <100%> (-0.02%) ⬇️
Libplanet.Tests/Store/StoreTest.cs 98.36% <100%> (-0.06%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 92.21% <100%> (-0.24%) ⬇️
Libplanet/Store/LiteDBStore.cs 89.11% <100%> (-0.22%) ⬇️
@moreal
moreal approved these changes Aug 28, 2019
@dahlia dahlia merged commit 68e521b into planetarium:master Aug 28, 2019
16 checks passed
16 checks passed
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 97.29% of diff hit (target 88.1%)
Details
codecov/project Absolute coverage decreased by -0.05% but relative coverage increased by +9.19% compared to a371911
Details
docs Libplanet docs generated by DocFX
Details
planetarium.libplanet Build #20190827.14 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.