Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #465 #474

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@dahlia
Copy link
Member

commented Aug 28, 2019

See also #465 (comment) and the changelog.

I'm going to fix Swarm<T>.SyncRecentStatesFromTrustedPeersAsync() method to find the proper branchpoint before sending GetRecentStates message in the master branch.

@dahlia dahlia added the bug label Aug 28, 2019

@dahlia dahlia added this to the 0.6.0 milestone Aug 28, 2019

@dahlia dahlia requested review from longfin, limebell, earlbread and moreal Aug 28, 2019

@dahlia dahlia self-assigned this Aug 28, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 28, 2019

Codecov Report

Merging #474 into 0.5-maintenance will decrease coverage by 0.01%.
The diff coverage is 100%.

@@                 Coverage Diff                 @@
##           0.5-maintenance     #474      +/-   ##
===================================================
- Coverage            87.96%   87.95%   -0.02%     
===================================================
  Files                  195      195              
  Lines                13698    13728      +30     
===================================================
+ Hits                 12050    12074      +24     
- Misses                1336     1342       +6     
  Partials               312      312
Impacted Files Coverage Δ
Libplanet.Tests/Store/StoreTest.cs 98.26% <100%> (+0.09%) ⬆️
Libplanet/Store/LiteDBStore.cs 89.19% <100%> (+0.02%) ⬆️
Libplanet/Net/Swarm.cs 78.97% <0%> (-0.26%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 92.34% <0%> (-0.21%) ⬇️

@dahlia dahlia merged commit 51d89c8 into planetarium:0.5-maintenance Aug 28, 2019

17 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 87.96%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +12.03% compared to d346aa7
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190828.16 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
limebell added a commit to limebell/libplanet that referenced this pull request Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.