Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download trusted states from a likely branchpoint #481

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@dahlia
Copy link
Member

commented Aug 30, 2019

See also changelogs.

@dahlia dahlia added the bug label Aug 30, 2019
@dahlia dahlia added this to the 0.6.0 milestone Aug 30, 2019
@dahlia dahlia requested review from longfin, limebell, earlbread and moreal Aug 30, 2019
@dahlia dahlia self-assigned this Aug 30, 2019
@dahlia dahlia dismissed stale reviews from earlbread and longfin via 863f578 Aug 30, 2019
@dahlia dahlia force-pushed the dahlia:bugfix/465 branch from f7b1264 to 863f578 Aug 30, 2019
@dahlia dahlia force-pushed the dahlia:bugfix/465 branch from 863f578 to 6e7249f Aug 30, 2019
@dahlia dahlia requested review from longfin and earlbread Aug 30, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 30, 2019

Codecov Report

Merging #481 into master will increase coverage by 0.23%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   88.12%   88.35%   +0.23%     
==========================================
  Files         195      195              
  Lines       13740    13779      +39     
==========================================
+ Hits        12108    12175      +67     
+ Misses       1320     1318       -2     
+ Partials      312      286      -26
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 81.17% <100%> (+0.93%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 92.72% <100%> (+0.18%) ⬆️
Libplanet/Net/Messages/GetRecentStates.cs 100% <100%> (+43.47%) ⬆️
Libplanet/Net/StateReferenceDownloadState.cs 66.66% <0%> (+66.66%) ⬆️
Libplanet/Net/BlockStateDownloadState.cs 75% <0%> (+75%) ⬆️
@moreal
moreal approved these changes Sep 2, 2019
@dahlia dahlia merged commit 97cd0dd into planetarium:master Sep 2, 2019
17 checks passed
17 checks passed
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 88.12%)
Details
codecov/project 88.35% (+0.23%) compared to 4c1c547
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190830.18 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.