Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore containing block hashes #484

Merged
merged 6 commits into from Sep 4, 2019

Conversation

@limebell
Copy link
Contributor

commented Sep 2, 2019

This resolves #461

@limebell limebell added the bug label Sep 2, 2019
@limebell limebell requested review from dahlia, longfin, earlbread and moreal Sep 2, 2019
@limebell limebell self-assigned this Sep 2, 2019
@limebell limebell force-pushed the limebell:bugfix-461 branch from 0a42340 to 3432f1a Sep 2, 2019
@limebell limebell added this to the 0.6.0 milestone Sep 2, 2019
CHANGES.md Outdated Show resolved Hide resolved
@codecov

This comment has been minimized.

Copy link

commented Sep 2, 2019

Codecov Report

Merging #484 into master will increase coverage by <.01%.
The diff coverage is 93.61%.

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
+ Coverage   89.93%   89.94%   +<.01%     
==========================================
  Files         200      200              
  Lines       14463    14506      +43     
==========================================
+ Hits        13008    13048      +40     
- Misses       1178     1181       +3     
  Partials      277      277
Impacted Files Coverage Δ
Libplanet.Tests/Net/SwarmTest.cs 97.85% <100%> (+0.05%) ⬆️
Libplanet/Net/Swarm.cs 81.43% <81.25%> (-0.06%) ⬇️
@limebell limebell force-pushed the limebell:bugfix-461 branch from 3432f1a to 531d685 Sep 2, 2019
@limebell limebell dismissed stale reviews from moreal, earlbread, and longfin via 1ff10c0 Sep 3, 2019
@limebell limebell force-pushed the limebell:bugfix-461 branch from 1ff10c0 to 725b49d Sep 3, 2019
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
@dahlia

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

@limebell Could we have some tests for the behavior added by this patch?

@limebell limebell force-pushed the limebell:bugfix-461 branch from 725b49d to efe8a23 Sep 3, 2019
@limebell limebell requested a review from dahlia Sep 3, 2019
@dahlia
dahlia approved these changes Sep 3, 2019
@longfin
longfin approved these changes Sep 3, 2019
@dahlia dahlia merged commit 5aa9c2d into planetarium:master Sep 4, 2019
17 checks passed
17 checks passed
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 93.61% of diff hit (target 89.93%)
Details
codecov/project 89.94% (+<.01%) compared to 35af052
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190903.24 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.