Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Swarm<T> with NetMQRuntime #485

Merged
merged 11 commits into from Oct 7, 2019

Conversation

@longfin
Copy link
Member

longfin commented Sep 2, 2019

This PR introduces NetMQRuntime to use async features. to accomplish it, this PR made changes as below.

  • Swarm<T> became IDisposable to handle its own runtime process(task).
  • Libplanet.Test project became to target .net471 since NetMQRuntime requires .net47 or above.
    • Dropped Microsoft.DotNet.Analyzer.Compatibility to work on macOS + Mono build.
  • Deleted Swarm<T>._dealers and it creates a new DealerSocket for each request even if already know remote.
  • Tuned mono options. (max thread, server mode)
@longfin longfin force-pushed the longfin:feature/netmq-runtime branch 2 times, most recently from 6cec5f0 to 6cff67c Sep 2, 2019
@longfin longfin referenced this pull request Sep 3, 2019
@longfin longfin force-pushed the longfin:feature/netmq-runtime branch 10 times, most recently from 18ccd17 to bf2078e Sep 3, 2019
@longfin longfin self-assigned this Sep 4, 2019
@longfin longfin force-pushed the longfin:feature/netmq-runtime branch 16 times, most recently from 185f7a1 to 9ea0fcb Sep 4, 2019
@dahlia dahlia referenced this pull request Oct 1, 2019
@longfin longfin dismissed stale reviews from moreal, dahlia, and earlbread via 89b390e Oct 4, 2019
@longfin longfin force-pushed the longfin:feature/netmq-runtime branch from 50fa46a to 89b390e Oct 4, 2019
@longfin longfin requested review from limebell, earlbread, dahlia and moreal Oct 7, 2019
CHANGES.md Outdated Show resolved Hide resolved
longfin and others added 11 commits Sep 3, 2019
- Split SendMessageWithReply and re-use it
- Adopt NetMQRuntime for sending socket
- Use netmq async method
- Ignore exception during disposing
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
@longfin longfin force-pushed the longfin:feature/netmq-runtime branch from 89b390e to b7187ad Oct 7, 2019
@moreal
moreal approved these changes Oct 7, 2019
@longfin longfin merged commit 9f55530 into planetarium:master Oct 7, 2019
17 of 18 checks passed
17 of 18 checks passed
dist
Details
docs
Details
codecov/patch 87.46% of diff hit (target 90.49%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 90.83% (+0.34%) compared to 09a3706
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191007.4 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.