Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace free string namespace with UUID (Guid) #486

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@dahlia
Copy link
Member

commented Sep 2, 2019

Fixes #483. See changelogs as well.

I believe this is substitutive for #482.

@dahlia dahlia added this to the 0.6.0 milestone Sep 2, 2019
@dahlia dahlia requested review from longfin, limebell, earlbread and moreal Sep 2, 2019
@dahlia dahlia self-assigned this Sep 2, 2019
Copy link
Member

left a comment

ChainIdNotFoundException summary need to be fixed, too.

CHANGES.md Outdated Show resolved Hide resolved
Libplanet/Store/IStore.cs Outdated Show resolved Hide resolved
Libplanet/Store/IStore.cs Outdated Show resolved Hide resolved
Libplanet/Store/IStore.cs Outdated Show resolved Hide resolved
Libplanet/Store/LiteDBStore.cs Outdated Show resolved Hide resolved
Libplanet/Store/LiteDBStore.cs Outdated Show resolved Hide resolved
Libplanet/Store/ChainIdNotFoundException.cs Outdated Show resolved Hide resolved
Libplanet/Store/ChainIdNotFoundException.cs Outdated Show resolved Hide resolved
@earlbread earlbread referenced this pull request Sep 2, 2019
@dahlia dahlia force-pushed the dahlia:store-chain-id branch from a7fbdc3 to 9497389 Sep 3, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 3, 2019

Codecov Report

Merging #486 into master will decrease coverage by 7.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   87.56%   80.17%   -7.39%     
==========================================
  Files         200       61     -139     
  Lines       14487     1513   -12974     
==========================================
- Hits        12685     1213   -11472     
+ Misses       1524      271    -1253     
+ Partials      278       29     -249
Impacted Files Coverage Δ
Libplanet/Net/Messages/BlockHashes.cs
Libplanet/Net/NoSwarmContextException.cs
Libplanet.Tests/Action/ActionEvaluationTest.cs
Libplanet/Blocks/Block.cs
...planet/Blockchain/Policies/BlockPolicyExtension.cs
Libplanet/Blocks/InvalidBlockTimestampException.cs
Libplanet/Tx/InvalidTxUpdatedAddressesException.cs
Libplanet/Net/StateReferenceDownloadState.cs
Libplanet/Action/ActionContext.cs
Libplanet/Action/ActionTypeAttribute.cs
... and 116 more
@codecov

This comment has been minimized.

Copy link

commented Sep 3, 2019

Codecov Report

Merging #486 into master will decrease coverage by 0.06%.
The diff coverage is 94.71%.

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   87.56%   87.49%   -0.07%     
==========================================
  Files         200      200              
  Lines       14487    14463      -24     
==========================================
- Hits        12685    12654      -31     
- Misses       1524     1536      +12     
+ Partials      278      273       -5
Impacted Files Coverage Δ
Libplanet/Store/BaseStore.cs 81.25% <ø> (ø) ⬆️
Libplanet/Store/BaseIndex.cs 30.18% <ø> (+0.55%) ⬆️
Libplanet.Tests/Store/StoreTrackerTest.cs 100% <100%> (ø) ⬆️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.41% <100%> (-0.01%) ⬇️
Libplanet/Blockchain/BlockChain.cs 94.2% <100%> (-0.23%) ⬇️
Libplanet/Net/Swarm.cs 75.8% <100%> (-1.13%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 93.64% <100%> (ø) ⬆️
Libplanet.Tests/Store/StoreFixture.cs 100% <100%> (ø) ⬆️
Libplanet/Store/StoreExtension.cs 95.55% <100%> (ø) ⬆️
Libplanet.Tests/Store/StoreExtensionTest.cs 100% <100%> (ø) ⬆️
... and 8 more
@dahlia dahlia requested a review from earlbread Sep 3, 2019
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@dahlia dahlia dismissed stale reviews from moreal and earlbread via 80a020e Sep 3, 2019
@dahlia dahlia force-pushed the dahlia:store-chain-id branch from 9497389 to 80a020e Sep 3, 2019
@dahlia dahlia force-pushed the dahlia:store-chain-id branch from 80a020e to d8b558d Sep 3, 2019
@dahlia dahlia requested review from limebell, moreal and earlbread Sep 3, 2019
@moreal
moreal approved these changes Sep 3, 2019
@longfin
longfin approved these changes Sep 3, 2019
@dahlia dahlia merged commit f51c667 into planetarium:master Sep 3, 2019
17 checks passed
17 checks passed
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 94.71% of diff hit (target 87.56%)
Details
codecov/project Absolute coverage decreased by -0.06% but relative coverage increased by +7.15% compared to c0882cd
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190903.7 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.