Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast transaction as soon as new transactions received #496

Merged
merged 3 commits into from Sep 4, 2019

Conversation

@limebell
Copy link
Contributor

commented Sep 4, 2019

This PR resolves #463.

@limebell limebell force-pushed the limebell:fix-463 branch from 716bb01 to b8802d6 Sep 4, 2019
@limebell limebell self-assigned this Sep 4, 2019
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@limebell limebell force-pushed the limebell:fix-463 branch 2 times, most recently from 83d9551 to 5d31b9f Sep 4, 2019
@limebell limebell requested review from dahlia, longfin, earlbread and moreal Sep 4, 2019
@limebell limebell added this to the 0.6.0 milestone Sep 4, 2019
CHANGES.md Outdated Show resolved Hide resolved
@limebell limebell force-pushed the limebell:fix-463 branch from 5d31b9f to 9e299d6 Sep 4, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 4, 2019

Codecov Report

Merging #496 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
- Coverage   89.96%   89.93%   -0.04%     
==========================================
  Files         200      200              
  Lines       14506    14506              
==========================================
- Hits        13051    13046       -5     
- Misses       1178     1183       +5     
  Partials      277      277
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 81.29% <100%> (-0.14%) ⬇️
Libplanet/Net/Protocols/KademliaProtocol.cs 60.23% <0%> (-0.88%) ⬇️
@limebell limebell dismissed stale reviews from earlbread and moreal via 9668bd1 Sep 4, 2019
@limebell limebell force-pushed the limebell:fix-463 branch from 9e299d6 to 9668bd1 Sep 4, 2019
@limebell limebell dismissed stale reviews from earlbread and dahlia via 037f6db Sep 4, 2019
@limebell limebell force-pushed the limebell:fix-463 branch from 037f6db to 3e17b70 Sep 4, 2019
@limebell

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

Actually AppendBlocksAsync should not call BroadcastBlocks, but currently there's no appropriate place for this so it's temporary in there.

@dahlia
dahlia approved these changes Sep 4, 2019
@moreal
moreal approved these changes Sep 4, 2019
@longfin longfin merged commit 7d66d36 into planetarium:master Sep 4, 2019
17 checks passed
17 checks passed
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 89.96%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +10.03% compared to 5aa9c2d
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190904.24 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.