Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnexpectedlyTerminatedActionException #498

Merged
merged 2 commits into from Sep 5, 2019

Conversation

@dahlia
Copy link
Member

commented Sep 4, 2019

For the sake of easier debugging, this patch makes action evaluation to throw UnexpectedlyTerminatedActionException with having its InnerException, BlockHash, BlockIndex, and TxId if an action throws an exception.

@dahlia dahlia added the suggestion label Sep 4, 2019
@dahlia dahlia added this to the 0.6.0 milestone Sep 4, 2019
@dahlia dahlia requested review from longfin, limebell, earlbread and moreal Sep 4, 2019
@dahlia dahlia self-assigned this Sep 4, 2019
@dahlia dahlia force-pushed the dahlia:action-eval-exception branch from 11132c6 to 4b6795d Sep 4, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 4, 2019

Codecov Report

Merging #498 into master will increase coverage by 0.01%.
The diff coverage is 78.26%.

@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   89.96%   89.98%   +0.01%     
==========================================
  Files         200      200              
  Lines       14506    14552      +46     
==========================================
+ Hits        13051    13095      +44     
+ Misses       1178     1173       -5     
- Partials      277      284       +7
Impacted Files Coverage Δ
Libplanet/Action/ActionEvaluation.cs 100% <100%> (+3.17%) ⬆️
...et/Action/UnexpectedlyTerminatedActionException.cs 100% <100%> (ø)
Libplanet/Tx/Transaction.cs 95.75% <100%> (+0.01%) ⬆️
Libplanet/Blockchain/BlockChain.cs 94.21% <100%> (ø) ⬆️
Libplanet.Tests/Tx/TransactionTest.cs 92.16% <66.66%> (-0.56%) ⬇️
Libplanet.Tests/Common/Action/ThrowException.cs 72% <80%> (+9.5%) ⬆️
@dahlia dahlia dismissed stale reviews from moreal, earlbread, and longfin via 934ead2 Sep 4, 2019
@dahlia dahlia force-pushed the dahlia:action-eval-exception branch from 4b6795d to 934ead2 Sep 4, 2019
@dahlia dahlia requested review from longfin, moreal and earlbread Sep 4, 2019
@longfin
longfin approved these changes Sep 4, 2019
@dahlia dahlia merged commit 21ac8d8 into planetarium:master Sep 5, 2019
16 of 17 checks passed
16 of 17 checks passed
codecov/patch 78.26% of diff hit (target 89.96%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 89.98% (+0.01%) compared to 7d66d36
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190904.41 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.