Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetState of block action to return proper state #500

Merged

Conversation

@earlbread
Copy link
Member

commented Sep 6, 2019

This fixes bug where GetState hadn't return proper state when the block action is evaluated.

@earlbread earlbread added the bug label Sep 6, 2019

@earlbread earlbread requested review from dahlia, longfin, limebell and moreal Sep 6, 2019

@earlbread earlbread self-assigned this Sep 6, 2019

@earlbread earlbread force-pushed the earlbread:fix-block-action-get-state branch from 3e47519 to 9053d29 Sep 6, 2019

@earlbread earlbread changed the base branch from master to 0.5-maintenance Sep 6, 2019

@earlbread

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

I rebased this on 0.5-maintenance branch.

@earlbread earlbread requested a review from limebell Sep 6, 2019

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Reword changelog
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>

@earlbread earlbread requested a review from dahlia Sep 6, 2019

@codecov

This comment has been minimized.

Copy link

commented Sep 6, 2019

Codecov Report

Merging #500 into 0.5-maintenance will decrease coverage by 0.02%.
The diff coverage is 100%.

@@                 Coverage Diff                 @@
##           0.5-maintenance     #500      +/-   ##
===================================================
- Coverage            88.04%   88.02%   -0.03%     
===================================================
  Files                  195      195              
  Lines                13770    13787      +17     
===================================================
+ Hits                 12124    12136      +12     
- Misses                1334     1339       +5     
  Partials               312      312
Impacted Files Coverage Δ
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.44% <100%> (+0.02%) ⬆️
Libplanet.Tests/Common/Action/MinerReward.cs 74.07% <100%> (+3.24%) ⬆️
Libplanet/Blockchain/BlockChain.cs 94.47% <100%> (-0.05%) ⬇️
Libplanet/Net/Swarm.cs 78.97% <0%> (-0.26%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 92.95% <0%> (-0.1%) ⬇️
@dahlia
dahlia approved these changes Sep 6, 2019

@dahlia dahlia closed this Sep 6, 2019

@earlbread earlbread reopened this Sep 9, 2019

@longfin
longfin approved these changes Sep 9, 2019
@moreal
moreal approved these changes Sep 9, 2019

@dahlia dahlia merged commit cb825cf into planetarium:0.5-maintenance Sep 9, 2019

15 of 19 checks passed

planetarium.libplanet Build #20190909.1 failed
Details
planetarium.libplanet (Linux_Mono) Linux_Mono failed
Details
planetarium.libplanet (Linux_Mono) Linux_Mono failed
Details
planetarium.libplanet
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 88.04%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +11.95% compared to 770879a
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details

@earlbread earlbread deleted the earlbread:fix-block-action-get-state branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.