Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swarm<T>.PreloadAsync() missing genesis states #512

Merged
merged 2 commits into from Sep 17, 2019

Conversation

@dahlia
Copy link
Member

commented Sep 11, 2019

This patch fixes a bug, made by 6e7249f, that Swarm<T>.PreloadAsync() silently misses the states resulted from actins in a genesis block (both tx actions and block actions) when it downloads states from trusted peers.

As the change made this bug hasn't been released yet, I skipped the changelog.

@dahlia dahlia added the bug label Sep 11, 2019
@dahlia dahlia added this to the 0.6.0 milestone Sep 11, 2019
@dahlia dahlia requested a review from planetarium/libplanet Sep 11, 2019
@dahlia dahlia self-assigned this Sep 11, 2019
CHANGES.md Show resolved Hide resolved
@codecov

This comment has been minimized.

Copy link

commented Sep 13, 2019

Codecov Report

Merging #512 into master will increase coverage by 0.05%.
The diff coverage is 98.73%.

@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
+ Coverage   90.07%   90.12%   +0.05%     
==========================================
  Files         201      201              
  Lines       14718    14791      +73     
==========================================
+ Hits        13257    13331      +74     
+ Misses       1177     1176       -1     
  Partials      284      284
Impacted Files Coverage Δ
Libplanet/Action/PolymorphicAction.cs 95.83% <0%> (-2.04%) ⬇️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.53% <100%> (+0.03%) ⬆️
Libplanet/Blockchain/BlockChain.cs 94.18% <100%> (+0.01%) ⬆️
Libplanet/Net/Swarm.cs 81.79% <100%> (+0.26%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 97.89% <100%> (+0.03%) ⬆️
Libplanet/Net/Protocols/KademliaProtocol.cs 61.44% <0%> (+0.57%) ⬆️
CHANGES.md Outdated Show resolved Hide resolved
@dahlia dahlia dismissed stale reviews from earlbread, moreal, limebell, and longfin via 083024e Sep 17, 2019
@dahlia dahlia force-pushed the dahlia:fix-preload-missing-genesis-states branch from b4820e2 to 083024e Sep 17, 2019
@dahlia dahlia requested review from longfin, limebell, moreal and earlbread Sep 17, 2019
@dahlia

This comment has been minimized.

Copy link
Member Author

commented Sep 17, 2019

@planetarium/libplanet Adjusted the changelog. Please approve this again.

@moreal
moreal approved these changes Sep 17, 2019
@dahlia dahlia merged commit 445b230 into planetarium:master Sep 17, 2019
17 checks passed
17 checks passed
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 98.73% of diff hit (target 90.07%)
Details
codecov/project 90.12% (+0.05%) compared to 738bb57
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190917.1 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.