Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the order of Block<T>.Transactions aware of their nonce #520

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@dahlia
Copy link
Member

commented Sep 18, 2019

See also the changelog and comments in the Block<T>() constructor.

@dahlia dahlia added the bug label Sep 18, 2019
@dahlia dahlia added this to the 0.6.0 milestone Sep 18, 2019
@dahlia dahlia requested review from longfin, limebell, earlbread and moreal Sep 18, 2019
@dahlia dahlia self-assigned this Sep 18, 2019
@dahlia dahlia force-pushed the dahlia:block-execute-tx-nonce-order branch from 7427167 to 5a8764e Sep 19, 2019
@dahlia dahlia requested a review from earlbread Sep 19, 2019
Libplanet/Blocks/Block.cs Outdated Show resolved Hide resolved
@dahlia dahlia dismissed stale reviews from moreal, limebell, and earlbread via 392508b Sep 19, 2019
@dahlia dahlia force-pushed the dahlia:block-execute-tx-nonce-order branch from 5a8764e to 392508b Sep 19, 2019
@dahlia dahlia requested review from limebell, earlbread and moreal Sep 19, 2019
@moreal
moreal approved these changes Sep 19, 2019
@dahlia dahlia merged commit 4a9aa2a into planetarium:master Sep 19, 2019
15 checks passed
15 checks passed
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190919.4 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
@codecov

This comment has been minimized.

Copy link

commented Sep 19, 2019

Codecov Report

Merging #520 into master will increase coverage by 10.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master     #520       +/-   ##
===========================================
+ Coverage   80.17%   90.18%   +10.01%     
===========================================
  Files          61      201      +140     
  Lines        1513    14890    +13377     
===========================================
+ Hits         1213    13429    +12216     
- Misses        271     1185      +914     
- Partials       29      276      +247
Impacted Files Coverage Δ
Libplanet/Blocks/Block.cs 90.64% <100%> (ø)
Libplanet.Tests/Blocks/BlockTest.cs 98.17% <100%> (ø)
Libplanet/Net/Messages/BlockHashes.cs 100% <0%> (ø)
Libplanet.Tests/Common/Action/BattleResult.cs 64.44% <0%> (ø)
Libplanet/Net/NoSwarmContextException.cs 0% <0%> (ø)
Libplanet.Tests/Action/ActionEvaluationTest.cs 96.66% <0%> (ø)
Libplanet.Tests/Store/StoreTest.cs 99.14% <0%> (ø)
Libplanet/Net/Messages/Pong.cs 100% <0%> (ø)
...planet/Blockchain/Policies/BlockPolicyExtension.cs 100% <0%> (ø)
Libplanet/Blocks/InvalidBlockTimestampException.cs 100% <0%> (ø)
... and 133 more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.