Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that LiteDBStore.ForkStateReferences<T>() throws ChainIdNotFoundException even if sourceChinId exists #522

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@dahlia
Copy link
Member

commented Sep 19, 2019

Fixed a bug that LiteDBStore.ForkStateReferences<T>() had thrown ChainIdNotFoundException where a sourceChainId exists but it has no state references (#509).

@dahlia dahlia force-pushed the dahlia:fix-chain-id-not-found-exception branch from 49b2af3 to 4cada83 Sep 19, 2019
@dahlia dahlia requested review from longfin, limebell, moreal and earlbread Sep 19, 2019
@dahlia dahlia self-assigned this Sep 19, 2019
@dahlia dahlia added the bug label Sep 19, 2019
@dahlia dahlia added this to the 0.6.0 milestone Sep 19, 2019
Copy link
Member

left a comment

Some tests seem to fail.

Fix #509
Fixed a bug that LiteDBStore.ForkStateReferences<T>() had thrown
ChainIdNotFoundException where a sourceChainId exists but
it has no state references.
@dahlia dahlia force-pushed the dahlia:fix-chain-id-not-found-exception branch from 4cada83 to e175c3d Sep 19, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 19, 2019

Codecov Report

Merging #522 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #522      +/-   ##
==========================================
- Coverage   90.21%   90.19%   -0.02%     
==========================================
  Files         201      201              
  Lines       14912    14914       +2     
==========================================
- Hits        13453    13452       -1     
- Misses       1182     1185       +3     
  Partials      277      277
Impacted Files Coverage Δ
Libplanet.Tests/Store/StoreFixture.cs 100% <ø> (ø) ⬆️
Libplanet.Tests/Store/StoreTest.cs 99.14% <100%> (ø) ⬆️
Libplanet/Store/LiteDBStore.cs 89.25% <100%> (ø) ⬆️
Libplanet/Net/Protocols/KademliaProtocol.cs 60% <0%> (-0.87%) ⬇️
@dahlia dahlia requested a review from longfin Sep 19, 2019
@dahlia dahlia merged commit eaf8e45 into planetarium:master Sep 19, 2019
17 checks passed
17 checks passed
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 90.21%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +9.78% compared to 2e02a7a
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190919.15 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.