Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide richer data for the TipChanged event #526

Merged
merged 1 commit into from Sep 24, 2019

Conversation

@dahlia
Copy link
Member

commented Sep 23, 2019

Instead of providing only a new tip index, this patch adds a tip hash and a previous tip.

@dahlia dahlia added the suggestion label Sep 23, 2019
@dahlia dahlia added this to the 0.6.0 milestone Sep 23, 2019
@dahlia dahlia requested review from longfin, limebell, earlbread and moreal Sep 23, 2019
@dahlia dahlia self-assigned this Sep 23, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 23, 2019

Codecov Report

Merging #526 into master will increase coverage by 0.02%.
The diff coverage is 97.72%.

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
+ Coverage   90.32%   90.35%   +0.02%     
==========================================
  Files         201      201              
  Lines       15011    15047      +36     
==========================================
+ Hits        13558    13595      +37     
+ Misses       1175     1173       -2     
- Partials      278      279       +1
Impacted Files Coverage Δ
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.68% <100%> (+0.01%) ⬆️
Libplanet/Blockchain/BlockChain.cs 94.27% <95.23%> (+0.17%) ⬆️
Libplanet/Crypto/PrivateKey.cs 85.34% <0%> (-0.87%) ⬇️
Libplanet/Net/Swarm.cs 81.79% <0%> (+0.13%) ⬆️
CHANGES.md Outdated Show resolved Hide resolved
@dahlia dahlia dismissed stale reviews from earlbread and longfin via 8be5806 Sep 23, 2019
@dahlia dahlia force-pushed the dahlia:tip-changed branch from 206978c to 8be5806 Sep 23, 2019
@dahlia dahlia requested review from longfin and earlbread Sep 23, 2019
@moreal
moreal approved these changes Sep 23, 2019
@limebell

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2019

Great! 👍

@longfin longfin merged commit a1959a7 into planetarium:master Sep 24, 2019
17 checks passed
17 checks passed
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 97.72% of diff hit (target 90.32%)
Details
codecov/project 90.35% (+0.02%) compared to 6cf0c16
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190923.15 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.