Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expectedResponses in GetBlocksAsync #567

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@earlbread
Copy link
Member

commented Oct 8, 2019

This fixes expectedResponses parameter in GetBlocksAsync.
It should be 1 if the hashCount and request.ChunkSize are the same.

[changelog skip]
@earlbread earlbread requested review from dahlia, longfin, limebell and moreal Oct 8, 2019
@earlbread earlbread self-assigned this Oct 8, 2019
@longfin
longfin approved these changes Oct 8, 2019
@codecov

This comment has been minimized.

Copy link

commented Oct 8, 2019

Codecov Report

Merging #567 into master will decrease coverage by 0.01%.
The diff coverage is 57.14%.

@@            Coverage Diff            @@
##           master    #567      +/-   ##
=========================================
- Coverage   90.81%   90.8%   -0.02%     
=========================================
  Files         201     201              
  Lines       15213   15219       +6     
=========================================
+ Hits        13816   13819       +3     
- Misses       1107    1110       +3     
  Partials      290     290
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 85.51% <57.14%> (-0.15%) ⬇️
@earlbread earlbread merged commit 9885d6f into planetarium:master Oct 8, 2019
17 of 18 checks passed
17 of 18 checks passed
dist
Details
docs
Details
codecov/patch 57.14% of diff hit (target 90.81%)
Details
WIP Ready for review
Details
changelog Check was skipped.
Details
codecov/project 90.8% (-0.02%) compared to e7ccac6
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191008.4 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
@earlbread earlbread deleted the earlbread:fix-expected-responses branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.