Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access only blocks to related to render #575

Merged
merged 1 commit into from Oct 14, 2019

Conversation

@earlbread
Copy link
Member

earlbread commented Oct 11, 2019

This fixes a bug that accessed all blocks from the genesis block when a swap occurred.

@earlbread earlbread added the bug label Oct 11, 2019
@earlbread earlbread requested review from dahlia, longfin, limebell and moreal Oct 11, 2019
@earlbread earlbread self-assigned this Oct 11, 2019
CHANGES.md Outdated Show resolved Hide resolved
Libplanet/Blockchain/BlockChain.cs Outdated Show resolved Hide resolved
Libplanet/Blockchain/BlockChain.cs Outdated Show resolved Hide resolved
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #575 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
+ Coverage    90.8%   90.81%   +<.01%     
==========================================
  Files         201      201              
  Lines       15219    15232      +13     
==========================================
+ Hits        13820    13833      +13     
  Misses       1109     1109              
  Partials      290      290
Impacted Files Coverage Δ
Libplanet/Blockchain/BlockChain.cs 94.24% <100%> (+0.11%) ⬆️
@earlbread earlbread force-pushed the earlbread:fix-swap branch from a373a75 to e43bb99 Oct 11, 2019
@earlbread earlbread force-pushed the earlbread:fix-swap branch 2 times, most recently from 1843864 to e977b89 Oct 11, 2019
@earlbread

This comment has been minimized.

Copy link
Member Author

earlbread commented Oct 11, 2019

I fixed docs and random access when rendering.

@earlbread earlbread requested review from dahlia, limebell and longfin Oct 11, 2019
@earlbread earlbread force-pushed the earlbread:fix-swap branch from e977b89 to d658643 Oct 14, 2019
@earlbread earlbread requested a review from longfin Oct 14, 2019
@moreal
moreal approved these changes Oct 14, 2019
@dahlia
dahlia approved these changes Oct 14, 2019
@longfin longfin merged commit 612e68f into planetarium:master Oct 14, 2019
18 checks passed
18 checks passed
dist
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 90.8%)
Details
codecov/project 90.81% (+<.01%) compared to f273b66
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191014.1 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
@earlbread earlbread deleted the earlbread:fix-swap branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.