Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug that some actions were not rendered #579

Merged
merged 5 commits into from Oct 17, 2019

Conversation

@limebell
Copy link
Contributor

limebell commented Oct 14, 2019

This PR fixes a bug that some actions were not rendered which are included in blocks that were received by SyncPreviousBlocksAsync() method by adding BlockChain<T>.Render() method.

This also fixes a bug that some actions were rendered multiple times when sync happened.

@limebell limebell added the bug label Oct 14, 2019
@limebell limebell added this to the 0.7.0 milestone Oct 14, 2019
@limebell limebell requested a review from planetarium/libplanet Oct 14, 2019
@limebell limebell self-assigned this Oct 14, 2019
@limebell limebell force-pushed the limebell:fillblock-render branch 2 times, most recently from 670f5e5 to a95a5bc Oct 14, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #579 into master will increase coverage by 0.05%.
The diff coverage is 98.88%.

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   90.86%   90.92%   +0.05%     
==========================================
  Files         202      202              
  Lines       15565    15652      +87     
==========================================
+ Hits        14143    14231      +88     
  Misses       1130     1130              
+ Partials      292      291       -1
Impacted Files Coverage Δ
Libplanet/Blockchain/BlockChain.cs 94.99% <100%> (+0.49%) ⬆️
Libplanet.Tests/Common/Action/DumbAction.cs 80.39% <100%> (+0.25%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 98.99% <100%> (+0.04%) ⬆️
Libplanet/Net/Swarm.cs 85.98% <90.9%> (+0.14%) ⬆️
Libplanet/Net/Protocols/KademliaProtocol.cs 66.49% <0%> (-0.78%) ⬇️
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Blockchain/BlockChain.cs Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@limebell limebell force-pushed the limebell:fillblock-render branch 2 times, most recently from 52a4cc7 to f97b6f6 Oct 15, 2019
@limebell

This comment has been minimized.

Copy link
Contributor Author

limebell commented Oct 15, 2019

I increased max line limitation per file to 2500 because SwarmTest.cs have exceeded previous limit 2250.

CHANGES.md Outdated Show resolved Hide resolved
@limebell limebell force-pushed the limebell:fillblock-render branch from 1c80fbc to bd7ae89 Oct 16, 2019
@limebell limebell force-pushed the limebell:fillblock-render branch from bd7ae89 to f72f85f Oct 17, 2019
@limebell limebell requested review from longfin, dahlia, moreal and earlbread Oct 17, 2019
@dahlia
dahlia approved these changes Oct 17, 2019
@longfin longfin merged commit 25f13ef into planetarium:master Oct 17, 2019
18 checks passed
18 checks passed
dist
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 98.88% of diff hit (target 90.86%)
Details
codecov/project 90.92% (+0.05%) compared to 1d75db4
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191017.8 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.