Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor `Swarm<T>` constructor #581

Merged
merged 5 commits into from Oct 16, 2019

Conversation

@longfin
Copy link
Member

longfin commented Oct 15, 2019

This PR refactor Swarm<T>'s constructor as below

  • The linger parameter is replaced with waitFor in Swarm<T>.StopAsync().
  • The dialTimeout parameter is moved to Swarm<T>.PreloadAsync() and Swarm<T>.StartAsync().

And, it also makes some changes as below

  • Removed Swarm<T>._blockChain using the auto-implemented property.
  • Removed Swarm<T>._protocol using the auto-implemented property.
@longfin longfin self-assigned this Oct 15, 2019
@longfin longfin force-pushed the longfin:feature/refactor-swarm-ctor branch from b972018 to 7ea42f5 Oct 15, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #581 into master will increase coverage by 0.11%.
The diff coverage is 97.01%.

@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
+ Coverage   90.72%   90.84%   +0.11%     
==========================================
  Files         202      202              
  Lines       15542    15530      -12     
==========================================
+ Hits        14101    14108       +7     
+ Misses       1149     1130      -19     
  Partials      292      292
Impacted Files Coverage Δ
Libplanet.Tests/Net/SwarmTest.cs 98.94% <100%> (-0.01%) ⬇️
Libplanet/Net/Swarm.cs 85.79% <96.87%> (+1%) ⬆️
Libplanet/Net/Protocols/KademliaProtocol.cs 67.27% <0%> (+0.77%) ⬆️
@longfin longfin force-pushed the longfin:feature/refactor-swarm-ctor branch 4 times, most recently from 67e9f6e to 9d5810e Oct 15, 2019
@longfin longfin force-pushed the longfin:feature/refactor-swarm-ctor branch from 9d5810e to 57b94b5 Oct 15, 2019
@longfin longfin requested a review from libplanet Oct 15, 2019
@longfin longfin marked this pull request as ready for review Oct 15, 2019
@longfin longfin changed the title [WIP] Refactor `Swarm<T>` constructor Refactor `Swarm<T>` constructor Oct 15, 2019
@dahlia dahlia requested review from planetarium/libplanet and removed request for libplanet Oct 16, 2019
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
@longfin longfin dismissed stale reviews from moreal, limebell, and earlbread via f2dcd26 Oct 16, 2019
@dahlia
dahlia approved these changes Oct 16, 2019
@longfin longfin requested review from limebell, moreal and earlbread Oct 16, 2019
@longfin longfin merged commit 95c5e04 into planetarium:master Oct 16, 2019
20 checks passed
20 checks passed
dist
Details
dist
Details
docs
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 97.01% of diff hit (target 90.72%)
Details
codecov/project 90.84% (+0.11%) compared to 24a2e5a
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191016.8 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.