Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of KademliaProtocol<T>.RefreshTableAsync #593

Merged
merged 4 commits into from Oct 22, 2019

Conversation

@limebell
Copy link
Contributor

limebell commented Oct 17, 2019

Fixed a bug that KademliaProcol<T>.RefreshTableAsync() did not remove staled peers. And became to check only least recently used peers in each table to prevent too frequent live checking.

This closes #568.

@limebell limebell added this to the 0.7.0 milestone Oct 17, 2019
@limebell limebell requested review from dahlia, longfin, earlbread and moreal Oct 17, 2019
@limebell limebell self-assigned this Oct 17, 2019
@limebell limebell force-pushed the limebell:fix-refreshtable branch from 0221610 to c300899 Oct 17, 2019
@limebell limebell force-pushed the limebell:fix-refreshtable branch from c300899 to 5b8a93b Oct 17, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #593 into master will decrease coverage by 0.01%.
The diff coverage is 85.41%.

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
- Coverage    90.9%   90.88%   -0.02%     
==========================================
  Files         202      202              
  Lines       15699    15723      +24     
==========================================
+ Hits        14271    14290      +19     
- Misses       1130     1134       +4     
- Partials      298      299       +1
Impacted Files Coverage Δ
Libplanet/Net/Protocols/KBucket.cs 92.72% <84.21%> (+0.89%) ⬆️
Libplanet/Net/Protocols/KademliaProtocol.cs 67.49% <86.2%> (+0.22%) ⬆️
@limebell limebell dismissed stale reviews from earlbread and longfin via 7da2ded Oct 18, 2019
@limebell limebell force-pushed the limebell:fix-refreshtable branch from 5b8a93b to 7da2ded Oct 18, 2019
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@limebell limebell force-pushed the limebell:fix-refreshtable branch from 33db658 to aee325c Oct 21, 2019
@limebell limebell force-pushed the limebell:fix-refreshtable branch from aee325c to ca1f010 Oct 21, 2019
@limebell limebell force-pushed the limebell:fix-refreshtable branch from ca1f010 to b4d0889 Oct 22, 2019
@limebell limebell requested review from dahlia, longfin and moreal Oct 22, 2019
@limebell limebell requested a review from earlbread Oct 22, 2019
@moreal
moreal approved these changes Oct 22, 2019
@dahlia
dahlia approved these changes Oct 22, 2019
@earlbread earlbread merged commit ef099e0 into planetarium:master Oct 22, 2019
17 of 18 checks passed
17 of 18 checks passed
dist
Details
docs
Details
codecov/patch 85.41% of diff hit (target 90.9%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 90.88% (-0.02%) compared to 2ce8197
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191022.4 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.