Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update routing table when non-protocol-messages received #627

Conversation

@limebell
Copy link
Contributor

limebell commented Oct 28, 2019

This PR contains followings:

  • Update routing table when any messages are received. (Excluding replies)
  • Do not live check least recently used peer when a peer is updated.

For these changes, some tests were modified.

@limebell limebell requested review from dahlia, longfin, earlbread and moreal Oct 28, 2019
@limebell limebell self-assigned this Oct 28, 2019
@limebell limebell changed the title Update peer in protocol with non-protocol-messages Update routing table when non-protocol-messages received Oct 28, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #627 into master will decrease coverage by 7.94%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
- Coverage   88.17%   80.22%   -7.95%     
==========================================
  Files         217       61     -156     
  Lines       17152     1512   -15640     
==========================================
- Hits        15123     1213   -13910     
+ Misses       1153      270     -883     
+ Partials      876       29     -847
Impacted Files Coverage Δ
Libplanet.Stun/Stun/TurnClient.cs 0% <0%> (-74.74%) ⬇️
Libplanet/Net/Messages/BlockHashes.cs
Libplanet/Net/NoSwarmContextException.cs
Libplanet.Tests/Action/ActionEvaluationTest.cs
Libplanet.Tests/Store/StoreTest.cs
Libplanet/Net/Messages/FindNeighbors.cs
Libplanet/Blocks/Block.cs
...planet/Blockchain/Policies/BlockPolicyExtension.cs
Libplanet/Blocks/InvalidBlockTimestampException.cs
Libplanet/Tx/InvalidTxUpdatedAddressesException.cs
... and 143 more
@longfin

This comment has been minimized.

Copy link
Member

longfin commented Oct 29, 2019

It seems to need to rebase.

@limebell limebell force-pushed the limebell:update-peer-in-protocol-with-non-protocol-message branch from 2f94964 to afe6ebe Oct 29, 2019
@limebell

This comment has been minimized.

Copy link
Contributor Author

limebell commented Oct 29, 2019

I made Swarm<T> to update routing table when replies were received.

@limebell limebell requested a review from longfin Oct 29, 2019
@dahlia

This comment has been minimized.

Copy link
Member

dahlia commented Oct 29, 2019

/rebase

@libplanet libplanet force-pushed the limebell:update-peer-in-protocol-with-non-protocol-message branch from afe6ebe to 6b7ab8b Oct 29, 2019
CHANGES.md Outdated Show resolved Hide resolved
@limebell limebell force-pushed the limebell:update-peer-in-protocol-with-non-protocol-message branch from 6b7ab8b to 6eaab44 Oct 30, 2019
@limebell limebell requested a review from longfin Oct 30, 2019
@limebell limebell dismissed stale reviews from earlbread and longfin via 872bc5a Oct 30, 2019
@limebell limebell force-pushed the limebell:update-peer-in-protocol-with-non-protocol-message branch from 6eaab44 to 872bc5a Oct 30, 2019
@limebell limebell force-pushed the limebell:update-peer-in-protocol-with-non-protocol-message branch from 872bc5a to dd34366 Oct 30, 2019
@longfin

This comment has been minimized.

Copy link
Member

longfin commented Nov 1, 2019

/rebase

@libplanet libplanet dismissed stale reviews from moreal and longfin via 1197ddc Nov 1, 2019
@libplanet libplanet force-pushed the limebell:update-peer-in-protocol-with-non-protocol-message branch from dd34366 to 1197ddc Nov 1, 2019
@longfin
longfin approved these changes Nov 1, 2019
@longfin longfin requested review from earlbread and moreal Nov 1, 2019
@moreal
moreal approved these changes Nov 1, 2019
@longfin longfin merged commit 176967b into planetarium:master Nov 1, 2019
17 of 18 checks passed
17 of 18 checks passed
dist
Details
docs
Details
codecov/project 80.22% (-7.95%) compared to 7a719d7
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch Coverage not affected when comparing 7a719d7...1197ddc
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191101.3 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.